Fix as_bytes() test for big endian targets #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
reviewed
Oct 8, 2022
joshlf
reviewed
Oct 8, 2022
|
Awesome, thanks @frazar! Left a few comments. |
The tests for the as_bytes() method assumed that bytes are stored in little endian order, which is not the case for PowerPC. Fix the alignment tests so that they work on both little and big endian targets. Fixes google#23
frazar
force-pushed
the
fix-big-endian-tests
branch
from
8ed0321
to
059cfac
Compare
|
Great! Should be ready now. |
joshlf
approved these changes
Oct 9, 2022
|
Thanks again! |
|
May I ask you to add the "Hacktoberfest-accepted" label to this PR? Thanks! |
Done! |
|
Great, thanks! |
joshlf
pushed a commit
that referenced
this pull request
Aug 3, 2023
The tests for the `as_bytes` method assumed that bytes are stored in little endian order, which is not the case for PowerPC. Fix the alignment tests so that they work on both little and big endian targets. Fixes #23 Co-authored-by: Francesco Zardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for the as_bytes() method assumed that bytes are stored in little endian order, which is not the case for PowerPC. Fix the alignment tests so that they work on both little and big endian targets.
Fixes #23