Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can someone sync google/api/http.proto? #11

Closed
ivucica opened this issue Aug 17, 2018 · 1 comment
Closed

Can someone sync google/api/http.proto? #11

ivucica opened this issue Aug 17, 2018 · 1 comment
Assignees
@lukesneeringer

Comments

@ivucica
Copy link
Contributor

ivucica commented Aug 17, 2018

This not being synced causes go-genproto to ignore changes made internally googleapis/go-genproto#92, in turn causing grpc-ecosystem/grpc-gateway#712 to break because a valid change has been steamrolled by automation.
ivucica referenced this issue in googleapis/go-genproto Aug 17, 2018
@jba
regenerate (#89)
9739b9a 
* regenerate

* using latest protoc-gen-go
@ivucica ivucica mentioned this issue Aug 17, 2018
Closed
ivucica added a commit to ivucica/api-common-protos that referenced this issue Aug 17, 2018
@ivucica
google/api/http.proto: Add response_body.
15def4a 
This syncs this file with github.com/googleapis/googleapis.

Fixes googleapis#11.
ivucica added a commit to ivucica/api-common-protos that referenced this issue Aug 17, 2018
@ivucica
google/api/http.proto: Add response_body.
8810d8a 
This syncs this file with github.com/googleapis/googleapis.

Fixes googleapis#11.
@ivucica ivucica mentioned this issue Aug 17, 2018
Merged
@ivucica
Copy link
Contributor Author

ivucica commented Aug 17, 2018

I've created #12 but this will sync only the http.proto. Other files with changes will not be synced.

lukesneeringer pushed a commit that referenced this issue Aug 17, 2018
@ivucica @lukesneeringer
google/api/http.proto: Add response_body. (#12)
831766b 
This syncs this file with github.com/googleapis/googleapis.

Fixes #11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukesneeringer lukesneeringer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukesneeringer @ivucica