Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support HttpRule with field response" #730

Closed
wants to merge 1 commit into from

Conversation

ivucica
Copy link
Collaborator

@ivucica ivucica commented Aug 17, 2018

@ivucica
Copy link
Collaborator Author

ivucica commented Aug 17, 2018

FYI @doroginin @johanbrandhorst @achew22 I will roll this back immediately because we can easily roll forward once it's not friday.

@johanbrandhorst
Copy link
Collaborator

@ivucica LGTM

@johanbrandhorst johanbrandhorst self-assigned this Aug 17, 2018
@achew22
Copy link
Collaborator

achew22 commented Aug 17, 2018

LGTM. Let's not break weekend hackers

@ivucica
Copy link
Collaborator Author

ivucica commented Aug 17, 2018

Alright, the change to googleapis/api-common-protos has been merged already!

Looks like someone "just" needs to regenerate code in go-genproto and we may not need to merge this. I'll give it ~1.5h and then merge this rollback.

@codecov-io
Copy link

codecov-io commented Aug 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@e679739). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #730   +/-   ##
=========================================
  Coverage          ?   56.29%           
=========================================
  Files             ?       30           
  Lines             ?     3121           
  Branches          ?        0           
=========================================
  Hits              ?     1757           
  Misses            ?     1193           
  Partials          ?      171
Impacted Files Coverage Δ
protoc-gen-grpc-gateway/gengateway/template.go 55.76% <ø> (ø)
runtime/mux.go 44.16% <ø> (ø)
protoc-gen-grpc-gateway/descriptor/types.go 49.07% <ø> (ø)
protoc-gen-grpc-gateway/descriptor/registry.go 71.03% <ø> (ø)
protoc-gen-swagger/main.go 27.38% <ø> (ø)
runtime/handler.go 43.33% <0%> (ø)
protoc-gen-grpc-gateway/descriptor/services.go 75.54% <100%> (ø)
protoc-gen-swagger/genswagger/template.go 39.39% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e679739...15b2e49. Read the comment docs.

@johanbrandhorst
Copy link
Collaborator

@ivucica I got in touch with @jadekler, he says this should be fixed?

@johanbrandhorst
Copy link
Collaborator

Looks like we can close this?

@ivucica ivucica closed this Aug 21, 2018
@ivucica
Copy link
Collaborator Author

ivucica commented Aug 21, 2018

Done

@ivucica ivucica deleted the revert-712-httprule-with-response branch August 21, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants