removes stash logic, adds caching test for MemoryCache #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Yet another way to solve #1075 This is my preferred method. That way, users can handle |
tmatsuo
approved these changes
Oct 21, 2016
bshaffer
force-pushed
the
remove-stash-dependency
branch
from
3ed35a4
to
dbc0c54
Compare
|
sounds good too |
|
Docs on the GitHub main page (README.md) should be updated: remove the reference to Stash, replace with an example for MemoryCache (presumably phpFastCache?). Please include a link to the MemoryCache source. |
|
Would you mind filing an issue for this and we will get the readme updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.