Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addresses issues in some caching implementations where data is returned for expired items #138

Closed
wants to merge 1 commit into from
Closed

addresses issues in some caching implementations where data is returned for expired items #138

wants to merge 1 commit into from

Conversation

bshaffer
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2016
@tmatsuo
Copy link
Contributor

tmatsuo commented Oct 20, 2016

LGTM. Do you want to add a test?

@bshaffer bshaffer mentioned this pull request Oct 20, 2016
Closed
@bshaffer
Copy link
Contributor Author

@tmatsuo I'm leaning towards implementing googleapis/google-api-php-client#1085 instead, as the above call to isHit should not be required, and is only needed for tedious/Stash#327

@bshaffer bshaffer closed this Oct 24, 2016
@bshaffer bshaffer deleted the fix-stash-issue branch October 24, 2016 16:20
@dwsupplee dwsupplee mentioned this pull request Oct 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @tmatsuo @googlebot