Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vision: include original Likelihood score #1881

Closed
rtw opened this issue Dec 12, 2016 · 1 comment
Closed

vision: include original Likelihood score #1881

rtw opened this issue Dec 12, 2016 · 1 comment
Assignees
Labels
api: vision Issues related to the Cloud Vision API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@rtw
Copy link
Contributor

rtw commented Dec 12, 2016

It would be great if the likelihood of emotions was send back in the response from the visionClient.detectFaces function. It is useful to the client code so that it can make decisions on the comparison of emotions.

It's intentionally removed replaced with Booleans in the gteLikelihood_ function.

Is there a reason this is done? Do you want me to update it and submit a pull request?

@stephenplusplus
Copy link
Contributor

I agree, we should return that original value. A PR would be great and very appreciated! While you're in there, can you keep our current boolean conversion, and simply add back in the sorrowLikelihood property? In other words:

vision.detectFaces('image.jpg', function(err, faces, apiResponse) {
  // faces = [
  //   {
  //     ...
  //     confidence: 56.748849,
  //     anger: false,
  //     angerLikelihood: 1,
  //     blurred: false,
  //     blurredLikelihood: 1,
  //     headwear: false,
  //     headwearLikelihood: 1,
  //     joy: false,
  //     joyLikelihood: 1,
  //     sorrow: false,
  //     sorrowLikelihood: 1,
  //     surprise: false,
  //     surpriseLikelihood: 1,
  //     underExposed: false,
  //     underExposedLikelihood: 1
  //   }
  // ]
});

Thanks for bringing this up!

@stephenplusplus stephenplusplus added enhancement api: vision Issues related to the Cloud Vision API. labels Dec 14, 2016
@stephenplusplus stephenplusplus changed the title Likelihood vision: include original Likelihood score Dec 14, 2016
@bjwatson bjwatson added priority: p2 Moderately-important priority. Fix may not be included in next release. Status: Acknowledged labels Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

3 participants