Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1881 vision: include original Likelihood score #1887

Merged
merged 2 commits into from
Mar 13, 2017

Conversation

rtw
Copy link
Contributor

@rtw rtw commented Dec 14, 2016

Fixes #1881

Add the original likelihood value into the response from the vision api
alongside the boolean values

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 14, 2016
@rtw
Copy link
Contributor Author

rtw commented Dec 16, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 16, 2016
@stephenplusplus
Copy link
Contributor

Thank you very much :) I think the only thing missing before we merge is an update to the docs (in the JSDocs snippet above the method) and a test to confirm we're returning the original value. If you prefer, I'm happy to do these at a later time.

@stephenplusplus stephenplusplus added enhancement api: vision Issues related to the Cloud Vision API. labels Dec 16, 2016
rtw and others added 2 commits March 6, 2017 13:02
Add the original likelihood value into the response from the vision api
alongside the boolean values
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 6, 2017
@@ -960,12 +960,19 @@ Vision.prototype.detectCrops = function(images, options, callback) {
* // },
* // confidence: 56.748849,
* // anger: false,
* // angerLikelihood: 1,

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus stephenplusplus merged commit 3e943e9 into googleapis:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vision Issues related to the Cloud Vision API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants