Get to 100% branch coverage #225

tseaver · 2014-10-07T18:22:33Z

Exercise edge cases in branch statements.

Surfaced bug w/ unknown type passed to get_protobuf_attribute_and_value().

Surfaced bug w/ path element holding both id and name in Key.from_protobuf.

Cover edge condition in Key.to_protobuf where dataset has empty ID.

Cover edge conditions in Key.to_protobuf where path elements are missing keys.

Cover edge conditions in Key.{kind,id,name} where path is empty.

Edge cases in Query.ancestor w/ existing non-ancestor filters.

Don't worry about path elem w/o kind.

Edge case in ACL.__iter__ for empty role.

Exercise Connection.delete_bucket w/ 'force' passed as False.

gcloud/datastore/key.py

@@ -66,7 +66,7 @@ def from_protobuf(cls, pb, dataset=None):
            if element.HasField('id'):
                element_dict['id'] = element.id

-            elif element.HasField('name'):
+            if element.HasField('name'):


@dhermes

Incorporate feedback from @dhermes.

Document that we expect only one of 'id' or 'name' to be found, but DTRT anyway if both happen to be present.

tseaver · 2014-10-08T15:59:20Z

@dhermes Any further issues?

dhermes · 2014-10-08T16:30:26Z

LGTM

Get to 100% branch coverage

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@1b9ad76 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021

Source-Link: googleapis/synthtool@c5026b3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

) Co-authored-by: Dina Graves Portman <[email protected]>

* chore: update to gapic-generator-python 1.5.0 feat: add support for `google.cloud.<api>.__version__` PiperOrigin-RevId: 484665853 Source-Link: googleapis/googleapis@8eb249a Source-Link: googleapis/googleapis-gen@c8aa327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update version in gapic_version.py * add .release-please-manifest.json with correct version * set manifest to true in .github/release-please.yml * add release-please-config.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update to gapic-generator-python 1.6.0 feat(python): Add typing to proto.Message based class attributes feat(python): Snippetgen handling of repeated enum field PiperOrigin-RevId: 487326846 Source-Link: googleapis/googleapis@da380c7 Source-Link: googleapis/googleapis-gen@61ef576 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update path to snippet metadata json * chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use templated owlbot.py and setup.py * configure release-please to use manifest * run nox format session Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72

Source-Link: googleapis/synthtool@e44dc0c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:5ff7446edeaede81c3ed58b23a4e76a5403fba1350ce28478045657303b6479d

* chore: update copyright year to 2022 PiperOrigin-RevId: 431037888 Source-Link: googleapis/googleapis@b3397f5 Source-Link: googleapis/googleapis-gen@510b54e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.9.1](https://www.github.com/googleapis/python-texttospeech/compare/v2.9.0...v2.9.1) (2022-01-08) ### Documentation * Added virtualenv comment for clarity ([#225](https://www.github.com/googleapis/python-texttospeech/issues/225)) ([61a7fce](https://www.github.com/googleapis/python-texttospeech/commit/61a7fcec0611712cdb1692b830db4aaca4d411b0)) * update comments for ListVoicesRequest ([#229](https://www.github.com/googleapis/python-texttospeech/issues/229)) ([9ea340c](https://www.github.com/googleapis/python-texttospeech/commit/9ea340cee20298630a6a15bed0ed2df9f69b3d13)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <[email protected]>

…ts to new format (#225) * chore(samples): Snippet Generating System Preparing the SGS (Snippet Generating System) script to handle the burden of duplicated code in the samples. * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore(samples): Making linter ignore the test fixtures. * chore(samples): Update region tags that shouldn't be region tags. * chore(samples): Syntax fix for Python 3.6 * Removing the 3.8 walrus syntax * Fixing test requirements * chore(samples): Trying to make the tests work * Cleaning up noxfile. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Removing bonus requirements file as it confuses the system. * One more try to fix tests. * Changing README to make snippet bot happy * chore(samples): Changing the sampels structure to use SGS * Fixing some tests. * Adding custom hostname files. * Making tests work again. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Making lint happy. * Making tests run faster with parallelism. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * WIP. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Apply suggestions from code review Co-authored-by: Anthonios Partheniou <[email protected]> * Applying comments from review. Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@52aef91 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:36a95b8f494e4674dc9eee9af98961293b51b86b3649942aac800ae6c1f796d4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.2](https://www.github.com/googleapis/python-monitoring/compare/v2.5.1...v2.5.2) (2021-09-30) ### Bug Fixes * improper types in pagers generation ([4a8b823](https://www.github.com/googleapis/python-monitoring/commit/4a8b823061a03fd0e5c385c1fa0ac964b9a5597a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Change-Id: I0230ae19a14112009058100c0bb789a7d7a1543a Fixes #199 🦕

Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@7e1f6da Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:a1a891041baa4ffbe1a809ac1b8b9b4a71887293c9101c88e8e255943c5aec2d

…ry Authorization Continuous Validation logs (#225) * feat: Adds support for check-based platform policy evaluation to Binary Authorization Continuous Validation logs feat: Adds support for communicating configuration issues that prevent Continuous Validation from monitoring pods fix!: Remove unused unsupported_policy_event event_type from ContinuousValidationPodEvent PiperOrigin-RevId: 557146775 Source-Link: googleapis/googleapis@6c2b07f Source-Link: googleapis/googleapis-gen@828cab4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODI4Y2FiNDNhMGMzOWEyOGYxMDMxN2I0YjViMTI0YzczNWYyNDBmYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ic enums (#225) * feat: enable "rest" transport in Python for services supporting numeric enums PiperOrigin-RevId: 508143576 Source-Link: googleapis/googleapis@7a702a9 Source-Link: googleapis/googleapis-gen@6ad1279 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Add service_yaml_parameters to py_gapic_library BUILD.bazel targets PiperOrigin-RevId: 510187992 Source-Link: googleapis/googleapis@5edc235 Source-Link: googleapis/googleapis-gen@b0bedb7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjBiZWRiNzJlNDc2NWEzZTBiNjc0YTI4YzUwZWEwZjlhOWIyNmE4OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@703554a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9

tseaver added 9 commits October 7, 2014 13:38

100% branch coverage for gcloud.datastore.helpers.

80e47a7

Surfaced bug w/ unknown type passed to get_protobuf_attribute_and_value().

Toward 100% branch coverage for gcloud.datastore.key.

df45002

Surfaced bug w/ path element holding both id and name in Key.from_protobuf.

Toward 100% branch coverage for gcloud.datastore.key.

18d8640

Cover edge condition in Key.to_protobuf where dataset has empty ID.

Toward 100% branch coverage for gcloud.datastore.key.

0b17af9

Cover edge conditions in Key.to_protobuf where path elements are missing keys.

100% branch coverage for gcloud.datastore.key.

70570db

Cover edge conditions in Key.{kind,id,name} where path is empty.

100% branch coverage for gcloud.datastore.query.

21a3d02

Edge cases in Query.ancestor w/ existing non-ancestor filters.

100% branch coverage for gcloud.datastore.test_key.

4f35659

Don't worry about path elem w/o kind.

100% branch coverage for gcloud.storage.acl.

f4cf251

Edge case in ACL.__iter__ for empty role.

100% branch coverage for gcloud.storage.connection.

a3c0405

Exercise Connection.delete_bucket w/ 'force' passed as False.

beriberikix added the in progress label Oct 7, 2014

dhermes reviewed Oct 7, 2014
View reviewed changes

tseaver added 2 commits October 7, 2014 14:38

Don't derive from object w/o need.

b9bec6e

Incorporate feedback from @dhermes.

Appease pylint E261.

4ee2e17

tseaver added hygiene testing labels Oct 7, 2014

Add note to 'name' branch in Key.from_protobuf.

03c740d

Document that we expect only one of 'id' or 'name' to be found, but DTRT anyway if both happen to be present.

tseaver added a commit that referenced this pull request Oct 8, 2014

Merge pull request #225 from tseaver/100_pct_branch_coverage

ebfe199

Get to 100% branch coverage

tseaver merged commit ebfe199 into googleapis:master Oct 8, 2014

beriberikix removed the in progress label Oct 8, 2014

tseaver deleted the 100_pct_branch_coverage branch October 8, 2014 20:22

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore: release 2.7.0 (#225)

526a61e

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: release 2.7.0 (#225)

70176b3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: release 2.7.0 (#225)

269ffa1

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore: release 2.7.0 (#225)

aed34a3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore(deps): update dependency google-api-python-client to v2.32.0 (#225

0ca0643

) Co-authored-by: Dina Graves Portman <[email protected]>

parthea pushed a commit that referenced this pull request Aug 15, 2023

chore: use python-samples-reviewers (#225)

02a1543

parthea pushed a commit that referenced this pull request Aug 15, 2023

chore(deps): update dependency google-cloud-iam to v2.8.2 (#225)

28477be

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency google-cloud-bigquery to v3.1.0 (#225)

d49542a

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-bigquery to v2.27.1 (#225)

3246b46

parthea pushed a commit that referenced this pull request Sep 22, 2023

docs: fix README typo in PyPI link (#225)

6023edf

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-pubsub to v2.7.0 (#225)

56e4441

parthea pushed a commit that referenced this pull request Sep 22, 2023

docs: Added virtualenv comment for clarity (#225)

92addcd

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 1.9.0 (#225)

371bf12

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <[email protected]>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: Increase Batch Translate Text timeout (#225)

5dc76cb

Change-Id: I0230ae19a14112009058100c0bb789a7d7a1543a Fixes #199 🦕

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(python): rename default branch to main (#225)

87efba7

parthea added a commit that referenced this pull request Oct 21, 2023

docs: removes unnecessary period in python sample description (#225)

d0a2025

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore: release 2.7.0 (#225)

9b168a7

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get to 100% branch coverage #225

Get to 100% branch coverage #225

tseaver commented Oct 7, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Oct 8, 2014

dhermes commented Oct 8, 2014

Get to 100% branch coverage #225

Get to 100% branch coverage #225

Conversation

tseaver commented Oct 7, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Oct 8, 2014

dhermes commented Oct 8, 2014