Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get to 100% branch coverage #225

Merged
merged 12 commits into from
Oct 8, 2014
Merged

Get to 100% branch coverage #225

merged 12 commits into from
Oct 8, 2014

Commits on Oct 7, 2014

  1. 100% branch coverage for gcloud.datastore.helpers. 

    Surfaced bug w/ unknown type passed to get_protobuf_attribute_and_value().
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    80e47a7 View commit details
    Browse the repository at this point in the history

  2. Toward 100% branch coverage for gcloud.datastore.key. 

    Surfaced bug w/ path element holding both id and name in Key.from_protobuf.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    df45002 View commit details
    Browse the repository at this point in the history

  3. Toward 100% branch coverage for gcloud.datastore.key. 

    Cover edge condition in Key.to_protobuf where dataset has empty ID.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    18d8640 View commit details
    Browse the repository at this point in the history

  4. Toward 100% branch coverage for gcloud.datastore.key. 

    Cover edge conditions in Key.to_protobuf where path elements are missing keys.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    0b17af9 View commit details
    Browse the repository at this point in the history

  5. 100% branch coverage for gcloud.datastore.key. 

    Cover edge conditions in Key.{kind,id,name} where path is empty.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    70570db View commit details
    Browse the repository at this point in the history

  6. 100% branch coverage for gcloud.datastore.query. 

    Edge cases in Query.ancestor w/ existing non-ancestor filters.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    21a3d02 View commit details
    Browse the repository at this point in the history

  7. 100% branch coverage for gcloud.datastore.test_key. 

    Don't worry about path elem w/o kind.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    4f35659 View commit details
    Browse the repository at this point in the history

  8. 100% branch coverage for gcloud.storage.acl. 

    Edge case in ACL.__iter__ for empty role.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    f4cf251 View commit details
    Browse the repository at this point in the history

  9. 100% branch coverage for gcloud.storage.connection. 

    Exercise Connection.delete_bucket w/ 'force' passed as False.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    a3c0405 View commit details
    Browse the repository at this point in the history

  10. Don't derive from object w/o need. 

    Incorporate feedback from @dhermes.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    b9bec6e View commit details
    Browse the repository at this point in the history

  11. Appease pylint E261.

    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    4ee2e17 View commit details
    Browse the repository at this point in the history

  12. Add note to 'name' branch in Key.from_protobuf. 

    Document that we expect only one of 'id' or 'name' to be found, but
DTRT anyway if both happen to be present.
    @tseaver
    tseaver committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    03c740d View commit details
    Browse the repository at this point in the history