Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing support for API_KEY auth in translate. #2823

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Removing support for API_KEY auth in translate. #2823

merged 1 commit into from
Dec 6, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 6, 2016

@dhermes dhermes added auth api: translation Issues related to the Cloud Translation API API. labels Dec 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2016
tseaver
tseaver approved these changes Dec 6, 2016
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@dhermes dhermes merged commit 5f68b4a into googleapis:master Dec 6, 2016
@dhermes dhermes deleted the fix-2734 branch December 6, 2016 18:09
@dhermes dhermes mentioned this pull request Dec 9, 2016
Merged
@daspecster daspecster mentioned this pull request Dec 28, 2016
Closed
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes
Merge pull request googleapis#2823 from dhermes/fix-2734
26158b6 
Removing support for API_KEY auth in translate.
@lukesneeringer
Copy link
Contributor

lukesneeringer commented Jul 28, 2017 •
edited
Loading

Hey folks -- what was the reason why we did this? I went down the rabbit hole and I can see that everyone agreed it was a good idea, but nowhere can I find an explanation as to why.

Cards on table: I had a "bug" filed on this recently (internal folks: b/64123162), and so I need to grok what the appropriate answer is (e.g. whether to put this support back, or say that we are not going to do it because ______).

@daspecster
Copy link
Contributor

@lukesneeringer, as I recall, it was mostly because the API key auth was outside of the normal authentication methods and I believe it was said that API key based auth was going away..or they(backend) were trying to not support it in the future.

@tseaver
Copy link
Contributor

tseaver commented Jul 28, 2017

@lukesneeringer the description @daspecster gave matches my memory. Sort of an extension of "Special cases aren't special enough to break the rules."

@theacodes
Copy link
Contributor

API keys are strongly being discouraged for Cloud APIs, especially for client libraries targeting backend languages. Omar has more details. :)

@lukesneeringer
Copy link
Contributor

Thanks. :-)

@lukesneeringer lukesneeringer mentioned this pull request Aug 4, 2017
Closed
parthea pushed a commit that referenced this pull request Oct 21, 2023
@dhermes
Merge pull request #2823 from dhermes/fix-2734
d3f0558 
Removing support for API_KEY auth in translate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@tseaver tseaver tseaver approved these changes

Assignees

@tseaver tseaver

Labels
api: translation Issues related to the Cloud Translation API API. auth cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dhermes @lukesneeringer @daspecster @tseaver @theacodes @googlebot