Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions for mega-release. #2846

Merged
merged 3 commits into from
Dec 10, 2016
Merged

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 8, 2016

We want to update

  • google-cloud-bigquery
  • google-cloud-datastore
  • google-cloud-logging
  • google-cloud-storage
  • google-cloud-core

And then update google-cloud to re-wrap the latest versions of each.

However, to avoid having packages in google-cloud with conflicting versions of google-cloud-core, we must release all packages.

See also: googleapis/google-cloud-python-happybase#19

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Dec 8, 2016

@jonparrott I realized I needed patch updates for BigQuery and Language, so there is a teeny commit since you approved. So sorry.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 8, 2016

@bjwatson I'd really like to get #2844 in, which requires you giving the 👍 to 1.0.2rc0 so there can be a real-live 1.0.2 /cc @nathanielmanistaatgoogle

Though we may just cut these releases today and say shucks.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 8, 2016

BigQuery

git log bigquery-0.22.0..ya-release -- bigquery/

Bigtable

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- bigtable/

Core

$ git log core-0.22.0..ya-release -- core/

Only change is #2828 (and version bump)

Datastore

git log 0.21.0..ya-release -- datastore/

DNS

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- dns/

Error Reporting

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- error_reporting/

Natural Language

$ git log language-0.22.0..ya-release -- language/

reveals #2841 is only change in source. The only reason to bump is the core bump, which has #2828

Logging

git log 0.21.0..ya-release -- logging/

Monitoring

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- monitoring/

Pub / Sub

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- pubsub/

Resource Manager

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- resource_manager/

Runtime Config

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- runtimeconfig/

Speech

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- speech/

Storage

git log 0.21.0..ya-release -- storage/

Translate

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- translate/

Vision

git log --abbrev-commit --pretty=format:"%h %s" 0.21.0..HEAD -- vision/

@daspecster
Copy link
Contributor

@dhermes I filled in the notes. LMK if there's anything else I can do to help with this!

@dhermes
Copy link
Contributor Author

dhermes commented Dec 9, 2016

@daspecster 0.21.1..HEAD is (probably) the wrong range for most of these. google-cloud was the only thing released at 0.21.1, everything else at 0.21.0 (except for the ones that have already started their own tag family: core-*, bigquery-* and language-*)

@daspecster
Copy link
Contributor

@dhermes good call. I updated the notes. There were a few PRs missing from between the 0.21.1.

@bjwatson
Copy link

bjwatson commented Dec 9, 2016

@dhermes Sorry for the delay. I was in bad shape yesterday. Doing much better today after lots of sleep.

The grpcio 1.0.2 release looks great, and I'm going to publish (gapic|grpc)-google-cloud-logging-v2 0.9.0 with a Beta development status.

@@ -50,13 +50,13 @@


REQUIREMENTS = [
'google-cloud-core >= 0.21.0, < 0.22dev',
'google-cloud-core >= 0.22.1, < 0.23dev',
'gapic-google-cloud-logging-v2 >= 0.14.0, < 0.15dev',

This comment was marked as spam.

This comment was marked as spam.

@@ -50,13 +50,13 @@


REQUIREMENTS = [
'google-cloud-core >= 0.21.0, < 0.22dev',
'google-cloud-core >= 0.22.1, < 0.23dev',
'grpcio >= 1.0.0, < 2.0dev',

This comment was marked as spam.

This comment was marked as spam.

We want to update

- `google-cloud-bigquery`
- `google-cloud-datastore`
- `google-cloud-logging`
- `google-cloud-storage`
- `google-cloud-core`

And then update `google-cloud` to re-wrap the latest
versions of each.

However, to avoid having packages in `google-cloud` with
conflicting versions of `google-cloud-core`, we must
release all packages.
Also upgrading logging from 0.14.x to 0.90.x
@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

OK I just added the grpcio >= 1.0.2 deps and switching to version 0.90 (time travel from 0.14) of logging.

I'm ready to push the big red button?

@tseaver
Copy link
Contributor

tseaver commented Dec 10, 2016

system-tests failure due to:

Collecting google-cloud-happybase<0.23dev,>=0.22.0 (from google-cloud==0.22.0)
  Could not find a version that satisfies the requirement google-cloud-happybase<0.23dev,>=0.22.0 (from google-cloud==0.22.0) (from versions: 0.20.0, 0.21.0)
No matching distribution found for google-cloud-happybase<0.23dev,>=0.22.0 (from google-cloud==0.22.0)

@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

Yup, same thing happened in googleapis/google-cloud-python-happybase#19, totally expected. Not sure how to resolve in general (I guess I could've pushed a b0rken happybase to PyPI first).

@dhermes dhermes merged commit 920345a into googleapis:master Dec 10, 2016
@dhermes dhermes deleted the ya-release branch December 10, 2016 17:26
@tseaver
Copy link
Contributor

tseaver commented Dec 10, 2016

@tseaver
Copy link
Contributor

tseaver commented Dec 10, 2016

It is likely a mistake that google-cloud pulls in google-cloud-happybase.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

@tseaver You think so? I did it on purpose when the umbrella came into existence, but maybe shouldn't have?

@tseaver
Copy link
Contributor

tseaver commented Dec 10, 2016

I think we should treat google-cloud-happybase as a "downstream" project, which a) breaks the cyclic dependency, and b) prevents resurrecting any licensing issue.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

SGTM, @jonparrott WDYT?


Also, I just did the following:

git tag 0.22.0
git tag bigquery-0.22.1
git tag bigtable-0.22.0
git tag core-0.22.1
git tag datastore-0.22.0
git tag dns-0.22.0
git tag error-reporting-0.22.0
git tag language-0.22.1
git tag logging-0.22.0
git tag monitoring-0.22.0
git tag pubsub-0.22.0
git tag resource-manager-0.22.0
git tag runtimeconfig-0.22.0
git tag speech-0.22.0
git tag storage-0.22.0
git tag translate-0.22.0
git tag vision-0.22.0

followed by

git push official 0.22.0
git push official bigquery-0.22.1
git push official bigtable-0.22.0
git push official core-0.22.1
git push official datastore-0.22.0
git push official dns-0.22.0
git push official error-reporting-0.22.0
git push official language-0.22.1
git push official logging-0.22.0
git push official monitoring-0.22.0
git push official pubsub-0.22.0
git push official resource-manager-0.22.0
git push official runtimeconfig-0.22.0
git push official speech-0.22.0
git push official storage-0.22.0
git push official translate-0.22.0
git push official vision-0.22.0

Now we'll see if the CircleCI deploy to PyPI works

@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

Here are the tag builds:

@theacodes
Copy link
Contributor

theacodes commented Dec 10, 2016 via email

@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

OK sent #2852.

As for the two builds that didn't trigger, it is indeed I who have the stupid. My regex isn't build to pick them up:

(([a-z]+)-)?([0-9]+)\.([0-9]+)\.([0-9]+)

Similarly, the Python regex doesn't pick it up:

$ CIRCLE_TAG=error-reporting-0.22.0 python scripts/circleci_tagged_pkg.py
Invalid tag name: error-reporting-0.22.0. Expected ^((?P<pkg>[a-z]+)-)?([0-9]+)\.([0-9]+)\.([0-9]+)$

@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

@jonparrott It's worth noting that all of those tag builds were throttled, with the worst waiting an hour to run:

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/540#usage-queue/containers/0

On the plus side, it's great that CircleCI tells us how long they were throttled and tells us what builds caused them to get stuck in a queue

@dhermes
Copy link
Contributor Author

dhermes commented Dec 10, 2016

OK, for now, I manually finished pushing:

$ cd error_reporting
$ python setup.py sdist bdist_wheel
$ twine upload dist/*
$
$ cd ../resource_manager
$ python setup.py sdist bdist_wheel
$ twine upload dist/*
$
$ cd ..
$ git clone [email protected]:a4e097f2f80fd490b256fc3aa2b4a46b.git
$ cd a4e097f2f80fd490b256fc3aa2b4a46b/
$ python setup.py sdist bdist_wheel
$ twine upload dist/*

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
atulep pushed a commit that referenced this pull request Apr 3, 2023
Update versions for mega-release.
atulep pushed a commit that referenced this pull request Apr 18, 2023
Update versions for mega-release.
parthea pushed a commit that referenced this pull request Jun 4, 2023
Update versions for mega-release.
parthea pushed a commit that referenced this pull request Jul 6, 2023
Update versions for mega-release.
parthea pushed a commit that referenced this pull request Oct 21, 2023
Update versions for mega-release.
parthea pushed a commit that referenced this pull request Oct 21, 2023
Update versions for mega-release.
parthea pushed a commit that referenced this pull request Oct 21, 2023
Update versions for mega-release.
parthea pushed a commit that referenced this pull request Oct 22, 2023
Update versions for mega-release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants