Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError if credentials are not from google-auth #2828

Merged
merged 21 commits into from
Dec 8, 2016
Merged

Raise ValueError if credentials are not from google-auth #2828

merged 21 commits into from
Dec 8, 2016

Conversation

theacodes
Copy link
Contributor

Resolves #2814

@theacodes theacodes added the auth label Dec 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2016
@theacodes
Copy link
Contributor Author

@dhermes PTAL - core only changes right now. Once you're cool with those I'll start fixing the unit tests for all other packages.

dhermes
dhermes reviewed Dec 6, 2016
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. What did you want me to see from this @jonparrott?

core/google/cloud/client.py
@@ -22,6 +23,13 @@
from google.cloud.credentials import get_credentials


_GOOGLE_AUTH_CREDENTIALS_HELP = (
'This library only supports credentials from google-auth-library-python. '

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/client.py
@@ -83,6 +91,10 @@ class Client(_ClientFactoryMixin):
_connection_class = Connection

def __init__(self, credentials=None, http=None):
if (credentials is not None and
not isinstance(
credentials, google.auth.credentials.Credentials)):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request Dec 7, 2016
Closed
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 7, 2016
@dhermes
Copy link
Contributor

dhermes commented Dec 7, 2016

Seems CircleCI has given up on pull requests, I'd guess yesterday's outage b0rked something

Jon Wayne Parrott added 2 commits December 7, 2016 14:41
@theacodes theacodes merged commit c4aa9df into googleapis:master Dec 8, 2016
@theacodes theacodes deleted the google-auth-or-die branch December 8, 2016 00:00
@dhermes dhermes mentioned this pull request Dec 8, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Raise ValueError if credentials are not from google-auth (googleapis#…
dea6029 
…2828)
atulep pushed a commit that referenced this pull request Apr 3, 2023
Raise ValueError if credentials are not from google-auth (#2828)
7355f65
atulep pushed a commit that referenced this pull request Apr 18, 2023
Raise ValueError if credentials are not from google-auth (#2828)
d402f10
parthea pushed a commit that referenced this pull request Jun 4, 2023
Raise ValueError if credentials are not from google-auth (#2828)
c175a53
parthea pushed a commit that referenced this pull request Oct 21, 2023
Raise ValueError if credentials are not from google-auth (#2828)
6cc743c
parthea pushed a commit that referenced this pull request Oct 21, 2023
Raise ValueError if credentials are not from google-auth (#2828)
3d6d725
parthea pushed a commit that referenced this pull request Oct 22, 2023
Raise ValueError if credentials are not from google-auth (#2828)
f798d8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@daspecster daspecster daspecster left review comments

Assignees
No one assigned
Labels
auth cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theacodes @googlebot @dhermes @daspecster