Explicitly putting 1.0.2rc0 lower bound on grpcio. #2844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
added
the
do not merge
tseaver
reviewed
Dec 8, 2016
| @@ -4,7 +4,7 @@ envlist = | |||
|
|
|||
| [testing] | |||
| deps = | |||
| grpcio | |||
| grpcio >= 1.0.2rc0 | |||
| mock | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
upgrade-grpcio
branch
from
9be0bf1
to
5e247a9
Compare
dhermes
force-pushed
the
upgrade-grpcio
branch
from
5e247a9
to
5053a3f
Compare
|
I deleted the CircleCI webhook, turned off the project and turned it back on, but CircleCI still won't trigger a build. What the heck |
|
@dhermes their support email is [email protected]. |
|
@daspecster Already sent an email, thanks though |
|
Now that 1.0.2 is out I'm putting it into #2846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labeled "don't merge" in the hopes that
1.0.2will be released soon and we don't need to depend on a release candidate. With this release, running e.g. system test eliminates the previous error (and hang on exit)/cc @bjwatson @nathanielmanistaatgoogle