Implementing storage regression tests to match gcloud-node. #319

dhermes · 2014-10-31T05:32:51Z

Not meant to be merged. Some missing features were
uncovered or hard to use APIs and I want to discuss here
and then map out the plan (i.e. how to break this up).

coveralls · 2014-10-31T05:35:58Z

Changes Unknown when pulling bdd28b6 on dhermes:storage-regression-tests into * on GoogleCloudPlatform:master*.

coveralls · 2014-10-31T20:34:48Z

Coverage remained the same when pulling 7185cb8 on dhermes:storage-regression-tests into 8e12e10 on GoogleCloudPlatform:master.

coveralls · 2014-10-31T23:23:02Z

Coverage remained the same when pulling 501bbe0 on dhermes:storage-regression-tests into 26d7eef on GoogleCloudPlatform:master.

dhermes · 2014-11-01T08:25:49Z

@tseaver or @silvolu, any comments on this?

coveralls · 2014-11-01T08:28:12Z

Coverage remained the same when pulling 4211f38 on dhermes:storage-regression-tests into 632e126 on GoogleCloudPlatform:master.

gcloud/storage/bucket.py

@@ -267,7 +267,8 @@ def upload_file(self, filename, key=None):
        if key is None:
            key = os.path.basename(filename)
        key = self.new_key(key)
-        return key.set_contents_from_filename(filename)
+        key.set_contents_from_filename(filename)
+        return key


coveralls · 2014-11-03T21:51:06Z

Coverage remained the same when pulling fb3b3ba on dhermes:storage-regression-tests into f33e557 on GoogleCloudPlatform:master.

gcloud/storage/bucket.py

@@ -276,7 +276,8 @@ def upload_file(self, filename, key=None):
        if key is None:
            key = os.path.basename(filename)
        key = self.new_key(key)
-        return key.set_contents_from_filename(filename)
+        key.upload_from_filename(filename)
+        return key


coveralls · 2014-11-03T22:38:26Z

Coverage remained the same when pulling 7f32773 on dhermes:storage-regression-tests into 2b73c7b on GoogleCloudPlatform:master.

coveralls · 2014-11-04T18:26:45Z

Coverage remained the same when pulling b48ce7a on dhermes:storage-regression-tests into abe3d7c on GoogleCloudPlatform:master.

coveralls · 2014-11-04T18:44:14Z

Coverage remained the same when pulling c9f948d on dhermes:storage-regression-tests into a410c6a on GoogleCloudPlatform:master.

Note meant to be merged. Some missing features were uncovered or hard to use APIs and I want to discuss here and then map out the plan (i.e. how to break this up).

coveralls · 2014-11-04T22:35:06Z

Coverage remained the same when pulling 16c5ad9 on dhermes:storage-regression-tests into 826ea69 on GoogleCloudPlatform:master.

dhermes · 2014-11-05T04:16:03Z

@tseaver This has been rebased on top of #332, PTAL.

I have yet to change the edit to Bucket.upload_file (where the Key is returned), but I can pursue the approach we discussed of constructing the key in the test.

tseaver · 2014-11-05T05:22:43Z

Ugh, I've lost the thread now of what I meant. I'd say go ahead and land it, and we'll work it out later if it comes clear.

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

- [ ] Regenerate this pull request now. feat: AuditConfig for IAM v1 fix(deps): require grpc-google-iam-v1 >=0.12.4 docs: fix type in docstring for map fields PiperOrigin-RevId: 440383959 Source-Link: googleapis/googleapis@6a276f6 Source-Link: googleapis/googleapis-gen@f94fc64 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjk0ZmM2NDA2MTgzNzAzM2JhYjg4YzY1MDc1ZTE4MTRlZGI2MTMzYSJ9

- [ ] Regenerate this pull request now. feat: release AttributesConfig APIs to v2 version feat: release CompletionConfig APIs to v2 version feat: add local inventories info to the Product resource docs: Improved documentation for Fullfillment and Inventory API in ProductService docs: minor documentation format and typo fixes PiperOrigin-RevId: 469399525 Source-Link: googleapis/googleapis@e9bcb6c Source-Link: googleapis/googleapis-gen@14169c6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTQxNjljNjQ1ZTY0MTc1YjQ0MWQ1OTljZGI1MDBjMTdmOTY0NDFiMiJ9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

docs: added notes to train agent prior to sending queries fix: added resource reference to agent_version PiperOrigin-RevId: 380595849 Source-Link: googleapis/googleapis@5fe3c63 Source-Link: googleapis/googleapis-gen@a2b223a * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

Source-Link: googleapis/synthtool@eb78c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163

* feat: add a FastSocket API PiperOrigin-RevId: 491381130 Source-Link: googleapis/googleapis@6485d9c Source-Link: googleapis/googleapis-gen@36f17cc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzZmMTdjYzk0ZTA3NjIzYWEzODRjYmQ0MGQ2OTRjMTExZTk3ZTQxYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

@medb

* chore: fix markdown format Committer: @medb PiperOrigin-RevId: 420314583 Source-Link: googleapis/googleapis@94ea1c4 Source-Link: googleapis/googleapis-gen@e19b9f5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTE5YjlmNTRkMDFhODk0MTUyMjcxYjU0Mzc0ZmJhMDFkZDIyNGI2MCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…p/templates/python_library/.kokoro (#319) Source-Link: https://togithub.com/googleapis/synthtool/commit/bb171351c3946d3c3c32e60f5f18cee8c464ec51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…319)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

fix(deps): require proto-plus >= 1.22.0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

dhermes added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: storage Issues related to the Cloud Storage API. testing labels Oct 31, 2014

dhermes force-pushed the storage-regression-tests branch from bdd28b6 to 7185cb8 Compare October 31, 2014 20:30

dhermes force-pushed the storage-regression-tests branch from 7185cb8 to 501bbe0 Compare October 31, 2014 23:18

dhermes force-pushed the storage-regression-tests branch from 501bbe0 to 4211f38 Compare November 1, 2014 08:25

tseaver reviewed Nov 3, 2014
View reviewed changes

dhermes force-pushed the storage-regression-tests branch from 4211f38 to fb3b3ba Compare November 3, 2014 21:38

dhermes reviewed Nov 3, 2014
View reviewed changes

dhermes mentioned this pull request Nov 3, 2014

Adding extra parameters for querying Cloud Storage keys. #332

Merged

dhermes force-pushed the storage-regression-tests branch from fb3b3ba to 7f32773 Compare November 3, 2014 22:31

dhermes mentioned this pull request Nov 4, 2014

Smooth out API surfaces before M1 #336

Closed

dhermes force-pushed the storage-regression-tests branch from 7f32773 to b48ce7a Compare November 4, 2014 18:18

dhermes force-pushed the storage-regression-tests branch from b48ce7a to c9f948d Compare November 4, 2014 18:36

Implementing storage regression tests to match gcloud-node.

16c5ad9

Note meant to be merged. Some missing features were uncovered or hard to use APIs and I want to discuss here and then map out the plan (i.e. how to break this up).

dhermes force-pushed the storage-regression-tests branch from c9f948d to 16c5ad9 Compare November 4, 2014 22:29

dhermes mentioned this pull request Nov 6, 2014

core: functional testing strategy #106

Closed

dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 6, 2014

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-documentai to v1.4.1 (#319)

b12b80d

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7.1.0 (#319)

ed38a67

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-talent to v2.9.1 (#319)

e751e77

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore(deps): update dependency google-cloud-language to v2.4.2 (#319)

7a5b337

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(main): release 1.10.0 (#319)

3ba7bcf

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: make samples 3.6 check optional (#319)

1f8f6c9

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.11.0 (#319)

f22958a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-texttospeech to v2.12.1 (#…

a007f6f

…319)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency backoff to v2.0.1 (#319)

43449c3

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 1.5.1 (#319)

8cc70fd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): require google-api-core>=1.31.5, >=2.3.2 (#319)

85ecdd9

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-analytics-admin to v0.14.1 (#319)

02eda76

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 2.6.0 (#319)

d1baca2

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): allow protobuf < 5.0.0 (#319)

b0c477f

fix(deps): require proto-plus >= 1.22.0

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 1.11.2 (#319)

7504f58

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing storage regression tests to match gcloud-node. #319

Implementing storage regression tests to match gcloud-node. #319

dhermes commented Oct 31, 2014

coveralls commented Oct 31, 2014

coveralls commented Oct 31, 2014

coveralls commented Oct 31, 2014

dhermes commented Nov 1, 2014

coveralls commented Nov 1, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 3, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 3, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

dhermes commented Nov 5, 2014

tseaver commented Nov 5, 2014

Implementing storage regression tests to match gcloud-node. #319

Implementing storage regression tests to match gcloud-node. #319

Conversation

dhermes commented Oct 31, 2014

coveralls commented Oct 31, 2014

coveralls commented Oct 31, 2014

coveralls commented Oct 31, 2014

dhermes commented Nov 1, 2014

coveralls commented Nov 1, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 3, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 3, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

dhermes commented Nov 5, 2014

tseaver commented Nov 5, 2014