Adding extra parameters for querying Cloud Storage keys. #332

dhermes · 2014-11-03T22:07:11Z

Will implement your suggestion in a 2nd commit.

Also notice in #319 that there should be an easier way to pass in extra_params than to manually create a _KeyIterator.

gcloud/storage/iterator.py

        self.connection = connection
        self.path = path
        self.page_number = 0
        self.next_page_token = None
+        self.extra_params = extra_params


coveralls · 2014-11-03T22:24:37Z

Changes Unknown when pulling cf1f2a9 on dhermes:add-params-to-key-iterator into * on GoogleCloudPlatform:master*.

coveralls · 2014-11-03T22:39:36Z

Coverage remained the same when pulling f6d9aee on dhermes:add-params-to-key-iterator into 2b73c7b on GoogleCloudPlatform:master.

gcloud/storage/iterator.py

        if self.next_page_token:
-            return {'pageToken': self.next_page_token}
+            result = {self.PAGE_TOKEN: self.next_page_token}


tseaver · 2014-11-04T17:55:30Z

LGTM beyond my clarity quibble.

coveralls · 2014-11-04T18:22:26Z

Coverage remained the same when pulling 062bba5 on dhermes:add-params-to-key-iterator into abe3d7c on GoogleCloudPlatform:master.

coveralls · 2014-11-04T18:43:32Z

Coverage remained the same when pulling 161ecbc on dhermes:add-params-to-key-iterator into a410c6a on GoogleCloudPlatform:master.

coveralls · 2014-11-04T21:50:55Z

Coverage remained the same when pulling 6851159 on dhermes:add-params-to-key-iterator into a410c6a on GoogleCloudPlatform:master.

gcloud/storage/iterator.py

@@ -69,8 +78,10 @@ def get_query_params(self):
        :rtype: dict or None
        :returns: A dictionary of query parameters or None if there are none.


Also making sure tests pass by using the `upload_` prefix instead of the `set_contents_` prefix.

dhermes · 2014-11-04T22:14:04Z

@tseaver Updated docstring (my bad) and rebased. PTAL

tseaver · 2014-11-04T22:18:57Z

LGTM.

coveralls · 2014-11-04T22:21:11Z

Coverage remained the same when pulling 2f28e9f on dhermes:add-params-to-key-iterator into aa22386 on GoogleCloudPlatform:master.

Adding extra parameters for querying Cloud Storage keys.

…rameters. See github issue googleapis#332

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 451250442 Source-Link: googleapis/googleapis@cca5e81 Source-Link: googleapis/googleapis-gen@0b219da Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9

…1.11.0 (#332)

Source-Link: googleapis/synthtool@06e8279 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <[email protected]>

* docs: Minor formatting chore: Update gapic-generator-python to v1.11.5 build: Update rules_python to 0.24.0 PiperOrigin-RevId: 563436317 Source-Link: googleapis/googleapis@42fd37b Source-Link: googleapis/googleapis-gen@280264c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * revert update for google-auth * add pin for google-cloud-storage for py < 3.7 Co-authored-by: Anthonios Partheniou <[email protected]>

* chore: update copyright year to 2022 PiperOrigin-RevId: 431037888 Source-Link: googleapis/googleapis@b3397f5 Source-Link: googleapis/googleapis-gen@510b54e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: update region tags to use correct product prefix * chore: update region tags to use correct product prefix * chore: update region tags to use correct product prefix

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@c4dd595 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72

* Update api_shortname in .repo-metadata.json * chore: Update api_shortname in .repo-metadata.json * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix replacement in owlbot.py * fix indent * restore coverage at 100% Co-authored-by: Anthonios Partheniou <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <[email protected]>

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * remove pin for python 3.6 Co-authored-by: Anthonios Partheniou <[email protected]>

* docs: Minor formatting chore: Update gapic-generator-python to v1.11.5 build: Update rules_python to 0.24.0 PiperOrigin-RevId: 563436317 Source-Link: googleapis/googleapis@42fd37b Source-Link: googleapis/googleapis-gen@280264c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

dhermes mentioned this pull request Nov 3, 2014

Implementing storage regression tests to match gcloud-node. #319

Merged

tseaver reviewed Nov 3, 2014
View reviewed changes

gcloud/storage/iterator.py

self.connection = connection

self.path = path

self.page_number = 0

self.next_page_token = None

self.extra_params = extra_params

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes force-pushed the add-params-to-key-iterator branch from cf1f2a9 to f6d9aee Compare November 3, 2014 22:31

dhermes added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 3, 2014

tseaver reviewed Nov 4, 2014
View reviewed changes

dhermes force-pushed the add-params-to-key-iterator branch from f6d9aee to 062bba5 Compare November 4, 2014 18:16

dhermes force-pushed the add-params-to-key-iterator branch from 062bba5 to 161ecbc Compare November 4, 2014 18:37

tseaver reviewed Nov 4, 2014
View reviewed changes

gcloud/storage/iterator.py

@@ -69,8 +78,10 @@ def get_query_params(self):

:rtype: dict or None

:returns: A dictionary of query parameters or None if there are none.

This comment was marked as spam.

Sign in to view

dhermes added 4 commits November 4, 2014 14:13

Adding extra parameters for querying Cloud Storage keys.

029249c

Testing interaction with page token and extra params in iterator.

88e5234

Also making sure tests pass by using the `upload_` prefix instead of the `set_contents_` prefix.

Using {} as default in iterator for extra_params and get_query_params.

018795f

Updating docstring in Iterator.get_query_params.

2f28e9f

dhermes force-pushed the add-params-to-key-iterator branch from 6851159 to 2f28e9f Compare November 4, 2014 22:13

dhermes added a commit that referenced this pull request Nov 4, 2014

Merge pull request #332 from dhermes/add-params-to-key-iterator

826ea69

Adding extra parameters for querying Cloud Storage keys.

dhermes merged commit 826ea69 into googleapis:master Nov 4, 2014

dhermes deleted the add-params-to-key-iterator branch November 4, 2014 22:24

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

fixed missing parentheses which throws an error when using default pa…

537cc99

…rameters. See github issue googleapis#332

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-recaptcha-enterprise to v…

c43c843

…1.11.0 (#332)

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.6.1 (#332)

42756f6

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 2.10.1 (#332)

19978ef

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-bigquery to v3.1.0 (#332)

fd9b45d

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 2.12.2 (#332)

ec69919

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency pytest to v7.1.3 (#332)

809ae0f

* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <[email protected]>

release-please bot mentioned this pull request Sep 20, 2023

chore: release main #11685

Closed

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 1.9.1 (#332)

6edf230

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.2.1 (#332)

4eb8609

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 2.9.2 (#332)

f463a2c

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-vision to v2.7.2 (#332)

3105b40

Co-authored-by: Anthonios Partheniou <[email protected]>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 0.16.1 (#332)

d10dee2

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023

chore(deps): update all dependencies (#332)

310c508

* chore(deps): update all dependencies * remove pin for python 3.6 Co-authored-by: Anthonios Partheniou <[email protected]>

release-please bot mentioned this pull request Oct 30, 2023

chore: release main #11913

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding extra parameters for querying Cloud Storage keys. #332

Adding extra parameters for querying Cloud Storage keys. #332

dhermes commented Nov 3, 2014

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 3, 2014

coveralls commented Nov 3, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

This comment was marked as spam.

dhermes commented Nov 4, 2014

tseaver commented Nov 4, 2014

coveralls commented Nov 4, 2014

		@@ -69,8 +78,10 @@ def get_query_params(self):
		:rtype: dict or None
		:returns: A dictionary of query parameters or None if there are none.

Adding extra parameters for querying Cloud Storage keys. #332

Adding extra parameters for querying Cloud Storage keys. #332

Conversation

dhermes commented Nov 3, 2014

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 3, 2014

coveralls commented Nov 3, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

coveralls commented Nov 4, 2014

This comment was marked as spam.

dhermes commented Nov 4, 2014

tseaver commented Nov 4, 2014

coveralls commented Nov 4, 2014