Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clients explicitly unpickleable. #3230

Merged
merged 4 commits into from
Mar 30, 2017
Merged

Make clients explicitly unpickleable. #3230

merged 4 commits into from
Mar 30, 2017

Conversation

lukesneeringer
Copy link
Contributor

Closes #3211.

@lukesneeringer lukesneeringer self-assigned this Mar 28, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2017
lukesneeringer
lukesneeringer commented Mar 28, 2017
View reviewed changes
core/google/cloud/client.py
@@ -14,6 +14,8 @@

"""Base classes for client used to interact with Google Cloud APIs."""

from pickle import PicklingError

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM. Style nit in the string creation. (I would say it's a "teeny performance hit" to create a new string at every use, but that would be wrong since the string is created right before program exit.)

core/google/cloud/client.py
@@ -14,6 +14,8 @@

"""Base classes for client used to interact with Google Cloud APIs."""

from pickle import PicklingError

This comment was marked as spam.

Sign in to view

core/google/cloud/client.py Outdated
@@ -126,6 +128,14 @@ def __init__(self, credentials=None, http=None):
credentials, self.SCOPE)
self._http_internal = http

def __getstate__(self):
"""Explicitly state that clients are not pickleable."""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/client.py Outdated
raise PicklingError('\n'.join([
'Pickling client objects is explicitly not supported.',
'Clients have non-trivial state that is local and unpickleable.',
]))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Mar 28, 2017 •
edited
Loading

I would say it's a "teeny performance hit" to create a new string at every use, but that would be wrong since the string is created right before program exit.

The teeny performance hit would be to create a new string at module import for everyone else.

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2017

Feel free to merge once you get CI green

@lukesneeringer lukesneeringer merged commit 0faaf54 into googleapis:master Mar 30, 2017
@lukesneeringer lukesneeringer deleted the issue-3211 branch March 30, 2017 14:51
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 30, 2017
@dhermes
Fixing usage of http= vs. _http= in core unit test.
be8632a 
Issue caused by two unrelated PRs merging in close
proximity: googleapis#3235 and googleapis#3230.
@dhermes dhermes mentioned this pull request Mar 30, 2017
Merged
lukesneeringer pushed a commit that referenced this pull request Mar 30, 2017
@dhermes @lukesneeringer
Fixing usage of http= vs. _http= in core unit test. (#3243)
6b1475c 
Issue caused by two unrelated PRs merging in close
proximity: #3235 and #3230.
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@lukesneeringer
Make clients explicitly unpickleable. (googleapis#3230)
26cfff9
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@dhermes @lukesneeringer
Fixing usage of http= vs. _http= in core unit test. (googleapis#3243)
9ded5f6 
Issue caused by two unrelated PRs merging in close
proximity: googleapis#3235 and googleapis#3230.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@theacodes theacodes theacodes approved these changes

Assignees

@lukesneeringer lukesneeringer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukesneeringer @dhermes @theacodes @googlebot