-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming http argument(s) as _http. #3235
Conversation
Done via several commands from the CLI: $ git grep -l use_gax | xargs sed -i s/use_gax/_use_grpc/g $ git grep -l __use_grpc | xargs sed -i s/__use_grpc/_use_grpc/g $ git grep -l USE_GAX | xargs sed -i s/USE_GAX/USE_GRPC/g $ git grep -l HAVE_GAX | xargs sed -i s/HAVE_GAX/HAVE_GRPC/g $ git grep -l DISABLE_GAX | xargs sed -i s/DISABLE_GAX/DISABLE_GRPC/g as well as some manual edits for indent / line length (only did this around `:param _use_grpc:`).
@lukesneeringer 👍 on your commit |
@lukesneeringer We all good here? |
Issue caused by two unrelated PRs merging in close proximity: googleapis#3235 and googleapis#3230.
@dhermes I just started getting errors that might have to do with this change. It's happening in my dataproc jobs, but I was able to reproduce the error in a fresh VM instance: $ sudo easy_install pip
$ sudo pip install google-cloud google-cloud-storage
$ python -c "from google.cloud import storage; storage.Client(project='<project>')"
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/google/cloud/storage/client.py", line 59, in
__init__
_http=_http)
TypeError: __init__() got an unexpected keyword argument '_http' I'm going to poke around the code in the VM to see what's up. |
I'd guess you have versions of |
Thanks for letting us know though! |
I ran |
@lukesneeringer @dhermes Is there background as to why the http object was made private? I haven't looked at this PR in detail yet, but has this change been made across all current clients? Future clients will adhere to the same contract? |
@supertom Yes this was made across all clients. It was done because we will be changing the underlying HTTP transport implementation, so making it part of the public interface was a bad idea (i.e. since we'd be breaking that interface). |
Issue caused by two unrelated PRs merging in close proximity: googleapis#3235 and googleapis#3230.
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <[email protected]>
Will also shortly be sending a commit to this PR which renames
use_gax
and_use_grpc
.grep
-ing forhttp
andhttp=
was pretty ad-hoc, so I'm not sure if there are lingering things needing to be changed (e.g. docs which refer tohttp
instead of_http
)Note in the commit about
use_gax
the following commands were used: