Falling back to implicit bucket in Blob constructor.

[dhermes]

Also making bucket required to exit the constructor.

NOTE: Has #584 as diffbase. (NOW MERGED)

[coveralls]

Coverage remained the same at 100.0% when pulling 4712d09 on dhermes:make-blob-use-implicit-bucket into d858ff0 on GoogleCloudPlatform:master.

[dhermes]

@tseaver Rebased after merging #584

[coveralls]

Coverage remained the same at 100.0% when pulling 48a10dc on dhermes:make-blob-use-implicit-bucket into 4f29529 on GoogleCloudPlatform:master.

[dhermes]

@tseaver rebased on top of #580.

It seems the only issue (at current) is importing Bucket (or not) in blob.py. Did you have something in mind other than an isinstance(bucket, Bucket) check in the constructor?

[coveralls]

Coverage remained the same at 100.0% when pulling 8506c76 on dhermes:make-blob-use-implicit-bucket into 9518db7 on GoogleCloudPlatform:master.

[tseaver]

Hmm, I still don't see where the import idea is coming from. I was proposing that we do all the checks for validity before assigning any instance attribute. E.g.:

    def __init__(self, name, bucket=None, properties=None):
        if name is None and properties is not None:
            name = properties.get('name')

        if bucket is None:
            bucket = _implicit_environ.BUCKET

        if bucket is None:
            raise ValueError('A Blob must have a bucket set.')

        super(Blob, self).__init__(name=name, properties=properties)

        self.bucket = bucket

[dhermes]

My bad, I wasn't reading closely enough. Fixed and folded into original commit. PTAL.

[coveralls]

Coverage remained the same at 100.0% when pulling 2d40ccd on dhermes:make-blob-use-implicit-bucket into 9518db7 on GoogleCloudPlatform:master.

[tseaver]

LGTM