feat: Make GAPIC Bazel rules production ready #402

vam-google · 2020-04-25T06:30:25Z

Shoud fix #400 and #390, plus a bunch of other not-yet-opened issues.

This includes:

Fix long initial load time (5+ min). This was caused by python_rules buildling grpcio dependency from sources in one core (which was super slow). Switched to using bazel-native "@com_github_grpc_grpc//src/python/grpcio/grpc:grpcio" target instead, which is not only much faster, but is also already used in googleapis, so there is no additional cost for reusing it in microgenerator rules.
Properly handle pandoc dependency (platform-sepcific version of pandoc is properly pulled by bazel itself using toolchains).
Add simplistic version of the py_gapic_assembly_pkg rule, to make output of microgenerator compatible with GAPICBazel class in synthtool.
Add plugin_args argument for python_gapic_library rule to pass custom argumetns to the plugin (similar to PHP rules).
Add compatibility with python3.6 runtime (otherwise python3.7 is minimum because of dependency on dataclasses module). Python 3.6 compatibility can be enabled by adding --define=gapic_gen_python=3.6 command line argument to bazel build command.
Add support for Python runtimes installed with pyenv. To tell bazel using Python3 installed via pyenv add --extra_toolchains=@gapic_generator_python//:pyenv3_toolchain argument to bazel build command.

This includes: 1) Fix long time initial load time (5+ min). This was caused by python_rules buildling `grpcio` dependency from sources in one core (which was super slow). Switched to using bazel-native `"@com_github_grpc_grpc//src/python/grpcio/grpc:grpcio"` target instead, which is not only much faster, but is also already used in googleapis, so there is no additional cost for reusing it in microgenerator rules. 2) Properly handle `pandoc` dependency (platform-sepcific version of pandoc is properly pulled by bazel itself using toolchains). 3) Add simplistic version of the `py_gapic_assembly_pkg` rule, to make output of microgenerator compatible with `GAPICBazel` class in synthtool. 4) Add `plugin_args` argument for python_gapic_library rule to pass custom argumetns to the plugin (similar to PHP rules).

vam-google · 2020-04-25T06:31:27Z

@software-dov @aohren PTAL

software-dov

I'm assuming the bazel bits are all correct. Just a few nits to pick

software-dov · 2020-04-27T20:59:06Z

WORKSPACE

+# Import grpc as a native bazel dependency. This avoids duplication and also
+# spedds up loading phase a lot (otherwise python_rules will be building grpcio
+# from sources in a single-core speed, which takes around 5 minutes on a regular
+# workstation)


Wat? Why is it building single-cored?

I dont know how exactly it does it, but based on time it takes and the CPU load on the build machine I assumed it must be single core

software-dov · 2020-04-27T21:03:44Z

rules_python_gapic/py_gapic_pkg.bzl

+    srcjar_srcs = []
+    for dep in ctx.attr.deps:
+        for f in dep.files.to_list():
+            if f.extension in ("srcjar", "jar", "zip"):
+                srcjar_srcs.append(f)


Does skylark allow list comprehensions? Personal preference, feel free to ignore, but I think

srcjar_srcs = [ dep_file for dep in ctx.attr.deps for dep_file in dep.files.to_list() if dep_file.extension in ("srcjar", "jar", "zip") ]

is more readable because of the indentation.

It is a reduced verison of more complicated for loops copied from the other rules. Starlak support list comprehension. For sake of style consistency with the other rules lets keep it like that.

software-dov · 2020-04-27T21:05:41Z

WORKSPACE

+
+#
+# Import grpc as a native bazel dependency. This avoids duplication and also
+# spedds up loading phase a lot (otherwise python_rules will be building grpcio


Nit: speeds

software-dov · 2020-04-29T21:54:16Z

Any updates or increased bandwidth?

vam-google · 2020-04-30T20:05:28Z

@software-dov Still trying to make CI work with gapic-generator-python (python3.7 requirement issue). Before that issue is solved this PR can't be used (can't integrate it in googleapis).

This includes: 1) Fix long time initial load time (5+ min). This was caused by python_rules buildling `grpcio` dependency from sources in one core (which was super slow). Switched to using bazel-native `"@com_github_grpc_grpc//src/python/grpcio/grpc:grpcio"` target instead, which is not only much faster, but is also already used in googleapis, so there is no additional cost for reusing it in microgenerator rules. 2) Properly handle `pandoc` dependency (platform-sepcific version of pandoc is properly pulled by bazel itself using toolchains). 3) Add simplistic version of the `py_gapic_assembly_pkg` rule, to make output of microgenerator compatible with `GAPICBazel` class in synthtool. 4) Add `plugin_args` argument for python_gapic_library rule to pass custom argumetns to the plugin (similar to PHP rules). 5) Add python3.6 support via `--define=gapic_gen_python.3.6` command line argument for for `bazel build command`. Otherwise gapic-generator-python can be executed only on systems with python3.7+.

vam-google · 2020-05-02T07:44:49Z

@software-dov PTAL. I finally made it wokr from kokoro under pyenv 3.6.1 python (the available on a kokoro instance)

software-dov

LG, just a few nits/questions.

software-dov · 2020-05-04T17:10:03Z

BUILD.bazel

+        ":gapic_gen_python_3_6": [requirement("dataclasses")],
+        "//conditions:default": [],
+    }),
+)


Nit: no newline

BUILD.bazel

pyenv3wrapper.sh

This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146

This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e

…ary generator. (#255) * Integrate Python GAPIC Microgenerator in googleapis. This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e * fix: add resource reference to proto files chore: update copyright and comments PiperOrigin-RevId: 309990843 Source-Author: Google APIs <[email protected]> Source-Date: Tue May 5 11:51:12 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 4bef0001ac7040431ea24b6187424fdec9c08b1b Source-Link: googleapis/googleapis@4bef000

This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e

Update comments on protos to clarify size limits on values. * Integrate Python GAPIC Microgenerator in googleapis. This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e * fix(python): use python installed by pyenv for bazel (#520) Source-Author: Jeff Ching <[email protected]> Source-Date: Mon May 4 15:52:28 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: a2c1c4f89a5e220e7b39420ebea33623c7c72804 Source-Link: googleapis/synthtool@a2c1c4f * Fix documentation for string_value. The value does not have to be at least 1MB, but rather, at most 1MB. PiperOrigin-RevId: 309845930 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 16:55:46 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 1b5a8d2bbb69c5a04db26bd546d2888e609c6bab Source-Link: googleapis/googleapis@1b5a8d2 * fix: make args optional (#521) Source-Author: Summer Ji <[email protected]> Source-Date: Tue May 5 09:52:17 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: ea3ae392fced25d7d6f5c7ef9c8a1f24768a0936 Source-Link: googleapis/synthtool@ea3ae39 * fix: make .kokoro-autosynth executable (#522) to fix googleapis/synthtool#519 Source-Author: Jeffrey Rennie <[email protected]> Source-Date: Tue May 5 10:12:11 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: ab883569eb0257bbf16a6d825fd018b3adde3912 Source-Link: googleapis/synthtool@ab88356 * fix: add resource reference to proto files chore: update copyright and comments PiperOrigin-RevId: 309990843 Source-Author: Google APIs <[email protected]> Source-Date: Tue May 5 11:51:12 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 4bef0001ac7040431ea24b6187424fdec9c08b1b Source-Link: googleapis/googleapis@4bef000

This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e

…ng documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e

* Integrate Python GAPIC Microgenerator in googleapis. This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e * chore(python): create thread_safety doc This will be included in index.rst files. See https://github.com/googleapis/python-bigtable/pull/26/files Source-Author: Bu Sun Kim <[email protected]> Source-Date: Tue May 5 10:06:52 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 09c48461232ce929c34386259eb59018ad2d8eef Source-Link: googleapis/synthtool@09c4846 * chore(python): remove extra #!/bin/bash Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Bu Sun Kim <[email protected]> Source-Date: Tue May 12 09:51:12 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 7482e79a82e353248769d819788adc1213e8c207 Source-Link: googleapis/synthtool@7482e79 * fix: avoid running out of disk space by cleaning up after each inner synth run Source-Author: Jeffrey Rennie <[email protected]> Source-Date: Fri May 15 10:53:36 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: fe8bbfdf2fef3bed8ebd461dcd33dfdd28604d02 Source-Link: googleapis/synthtool@fe8bbfd * fix: restore GAPIC v2 retry configs Restores GAPIC v2 retry config overrides that were mistakenly removed during migration. PiperOrigin-RevId: 312088359 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 08:57:12 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c Source-Link: googleapis/googleapis@5a90d46 * chore(python): remove one remaining extra bash line To avoid generating bogus PRs Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Carlos de la Guardia <[email protected]> Source-Date: Tue May 19 11:57:19 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e Source-Link: googleapis/synthtool@d2364eb * fix: bigtable v2 retry config settings to disable streaming RPC retries PiperOrigin-RevId: 312558019 Source-Author: Google APIs <[email protected]> Source-Date: Wed May 20 14:40:11 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: a175708acd7a367ab3ed120fa562331e1761d825 Source-Link: googleapis/googleapis@a175708 * Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings. PiperOrigin-RevId: 312689208 Source-Author: Google APIs <[email protected]> Source-Date: Thu May 21 10:00:47 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f Source-Link: googleapis/googleapis@dec3204 * bazel: update protobuf, rules_go, gazelle, and gapic-generator-go versions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1 PiperOrigin-RevId: 313460921 Source-Author: Google APIs <[email protected]> Source-Date: Wed May 27 14:10:16 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: c4e37010d74071851ff24121f522e802231ac86e Source-Link: googleapis/googleapis@c4e3701 * docs: update python docs template * docs: update python docs template * sphinx change Source-Author: kolea2 <[email protected]> Source-Date: Wed May 27 20:44:34 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 71b8a272549c06b5768d00fa48d3ae990e871bec Source-Link: googleapis/synthtool@71b8a27 * feat: add templates for python samples projects These templates will be used for templates in python-docs-samples and in Python client libraries. The README generation code is a modified version of https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/scripts/readme-gen. Co-authored-by: Kurtis Van Gent <[email protected]> Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 14:39:58 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: ffe10407ee2f261c799fb0d01bf32a8abc67ed1e Source-Link: googleapis/synthtool@ffe1040 * chore: update default ignores for Python libraries Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 14:43:37 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: e99975b6b49827b8720f0a885e218dbdb67849ca Source-Link: googleapis/synthtool@e99975b * feat: allow custom python versions in noxfile Libraries on the microgenerator support a smaller range of Python versions (3.6+). Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 18:22:04 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 4e1d2cb79b02d7496b1452f91c518630c207145e Source-Link: googleapis/synthtool@4e1d2cb * chore: update gapic-generator and go microgen changes include: - build_gen: go lro gapic used as dep - go_gapic_library: fixes shading of go_library importpath PiperOrigin-RevId: 314363155 Source-Author: Google APIs <[email protected]> Source-Date: Tue Jun 2 10:56:09 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 3a4894c4f0da3e763aca2c67bd280ae915177450 Source-Link: googleapis/googleapis@3a4894c * firestore: add BatchWrite PiperOrigin-RevId: 314471006 Source-Author: Google APIs <[email protected]> Source-Date: Tue Jun 2 22:32:52 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: d5fe42c39cd35f95131a0267314ae108ab1bef8d Source-Link: googleapis/googleapis@d5fe42c * chore: set Ruby namespace in proto options PiperOrigin-RevId: 316123861 Source-Author: Google APIs <[email protected]> Source-Date: Fri Jun 12 10:03:16 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 66f959b51c255dd6bef79ef221865e53a50df878 Source-Link: googleapis/googleapis@66f959b * fix: use protoc-docs-plugin 0.8.0 Fixes issue with missing newline before 'Attributes' in Python docstrings. PiperOrigin-RevId: 316182409 Source-Author: Google APIs <[email protected]> Source-Date: Fri Jun 12 14:52:11 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 184661793fbe3b89f2b485c303e7466cef9d21a1 Source-Link: googleapis/googleapis@1846617 * feat: retry CommitRequests that fail with UNAVAILABLE PiperOrigin-RevId: 316514901 Source-Author: Google APIs <[email protected]> Source-Date: Mon Jun 15 12:00:19 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 9b170a4f3beb16f7dab513520a07be48fcb88670 Source-Link: googleapis/googleapis@9b170a4 * fix(python): change autodoc_default_flags to autodoc_default_options Source-Author: HemangChothani <[email protected]> Source-Date: Thu Jun 18 22:50:02 2020 +0530 Source-Repo: googleapis/synthtool Source-Sha: cd522c3b4dde821766d95c80ae5aeb43d7a41170 Source-Link: googleapis/synthtool@cd522c3 * feat(python): add defaults for microgenerator libraries Source-Author: Bu Sun Kim <[email protected]> Source-Date: Mon Jun 22 17:56:27 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: db4f15fedc76e04018e6e43ec403e804e1142158 Source-Link: googleapis/synthtool@db4f15f * chore(python): fix line breaks in template and use newer black version * chore(python): fix line breaks in template * fix: also update black version Source-Author: Bu Sun Kim <[email protected]> Source-Date: Tue Jun 23 02:33:35 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: cf2eff09d0f5319a4dc5cdce2b6356d85af4a798 Source-Link: googleapis/synthtool@cf2eff0 * chore: manual regen * fix: more synth replaces * fix: more synth replaces * fix: fix the noxfile Co-authored-by: Bu Sun Kim <[email protected]> Co-authored-by: Bu Sun Kim <[email protected]>

…ng documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e

* Integrate Python GAPIC Microgenerator in googleapis. This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e * ci(java): switch to GitHub Actions * ci: switch to GitHub Actions * update based on comment Source-Author: Stephanie Wang <[email protected]> Source-Date: Mon May 11 12:54:00 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 55cdc844877d97139f25004229842624a6a86a02 Source-Link: googleapis/synthtool@55cdc84 * chore: move ci.yaml to workflows dir Source-Author: Stephanie Wang <[email protected]> Source-Date: Mon May 11 16:24:04 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 98c50772ec23295c64cf0d2ddf199ea52961fd4c Source-Link: googleapis/synthtool@98c5077 * docs: update CONTRIBUTING.md to include code formatting Co-authored-by: Jeff Ching <[email protected]> Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Brian Chen <[email protected]> Source-Date: Tue May 12 10:24:59 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 5b48b0716a36ca069db3038da7e205c87a22ed19 Source-Link: googleapis/synthtool@5b48b07 * fix: restore GAPIC v2 retry configs Restores GAPIC v2 retry config overrides that were mistakenly removed during migration. PiperOrigin-RevId: 312088359 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 08:57:12 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c Source-Link: googleapis/googleapis@5a90d46 * bazel: update protobuf, rules_go, gazelle, and gapic-generator-go versions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1 PiperOrigin-RevId: 313460921 Source-Author: Google APIs <[email protected]> Source-Date: Wed May 27 14:10:16 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: c4e37010d74071851ff24121f522e802231ac86e Source-Link: googleapis/googleapis@c4e3701 * firestore: add BatchWrite PiperOrigin-RevId: 314471006 Source-Author: Google APIs <[email protected]> Source-Date: Tue Jun 2 22:32:52 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: d5fe42c39cd35f95131a0267314ae108ab1bef8d Source-Link: googleapis/googleapis@d5fe42c * chore: turn on renovate-bot master issue for java repos Source-Author: Stephanie Wang <[email protected]> Source-Date: Thu Jun 4 18:23:16 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: cac9eef310652bf138dd76b716e4986e757d62ac Source-Link: googleapis/synthtool@cac9eef * build(java): skip lint on samples directory Let the samples test decide how to enforce linting Source-Author: Jeff Ching <[email protected]> Source-Date: Fri Jun 5 13:40:10 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 987270824bd26f6a8c716d5e2022057b8ae7b26e Source-Link: googleapis/synthtool@9872708 * chore: set Ruby namespace in proto options PiperOrigin-RevId: 316123861 Source-Author: Google APIs <[email protected]> Source-Date: Fri Jun 12 10:03:16 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 66f959b51c255dd6bef79ef221865e53a50df878 Source-Link: googleapis/googleapis@66f959b * ci(java): switch to secret manager from keystore * ci(java): switch to secret manager from keystore, use java-docs-samples user for samples tests * fix: we don't need to supply a service account Source-Author: Jeff Ching <[email protected]> Source-Date: Mon Jun 15 11:45:21 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: d1addcdf80aa9ddef8c932c89c919024bbad7af3 Source-Link: googleapis/synthtool@d1addcd * feat: retry CommitRequests that fail with UNAVAILABLE PiperOrigin-RevId: 316514901 Source-Author: Google APIs <[email protected]> Source-Date: Mon Jun 15 12:00:19 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 9b170a4f3beb16f7dab513520a07be48fcb88670 Source-Link: googleapis/googleapis@9b170a4 * samples(java): fix bad character in samples.cfg from copy/paste Somehow an invisible character was copy/pasted into the file and Kokoro cannot parse the file. Source-Author: Jeff Ching <[email protected]> Source-Date: Mon Jun 15 15:42:10 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 6d3eed67a45fd58f9c7bfa173c32e4fd4fed058f Source-Link: googleapis/synthtool@6d3eed6 * ci(java): run dependency test on Java 8 and 11 Redo fix in #633 with proper jinja templating format Source-Author: Jeff Ching <[email protected]> Source-Date: Fri Jun 19 16:52:15 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 4f2c9f752a94042472fc03c5bd9e06e89817d2bd Source-Link: googleapis/synthtool@4f2c9f7 * firestore: add BatchWrite to service config PiperOrigin-RevId: 318331819 Source-Author: Google APIs <[email protected]> Source-Date: Thu Jun 25 13:02:29 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 0a602be7b3835b51d59daf8f6f5dc2dc22f69d7e Source-Link: googleapis/googleapis@0a602be * firestore: add BatchWrite to gapic yaml PiperOrigin-RevId: 319105199 Source-Author: Google APIs <[email protected]> Source-Date: Tue Jun 30 14:56:36 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: cbd6f1d28bc0c461c234f9848bcbc1563126daf9 Source-Link: googleapis/googleapis@cbd6f1d * chore: update integration and samples credentials Co-authored-by: BenWhitehead <[email protected]>

…ng documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e

@miraleung

…1; make 'features' a positional param for annotate_video in betas (#31) * Integrate Python GAPIC Microgenerator in googleapis. This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e * chore(python): create thread_safety doc (#517) This will be included in index.rst files. See https://github.com/googleapis/python-bigtable/pull/26/files Source-Author: Bu Sun Kim <[email protected]> Source-Date: Tue May 5 10:06:52 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 09c48461232ce929c34386259eb59018ad2d8eef Source-Link: googleapis/synthtool@09c4846 * chore(python): remove extra #!/bin/bash (#538) Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Bu Sun Kim <[email protected]> Source-Date: Tue May 12 09:51:12 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 7482e79a82e353248769d819788adc1213e8c207 Source-Link: googleapis/synthtool@7482e79 * chore!: enable gapicv2 for monitoring/v3 API This introduces the following breakages upon code regeneration, which are due to the `TimeSeriesQueryLanguageCondition` type being removed from `alert.proto` in a preceding change. ``` [ERROR] 6011: com.google.monitoring.v3.AlertPolicy$Condition: Field CONDITION_TIME_SERIES_QUERY_LANGUAGE_FIELD_NUMBER has been removed, but it was previously a constant [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder clearConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder getConditionTimeSeriesQueryLanguageBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder mergeConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder)' has been removed [ERROR] 6001: com.google.monitoring.v3.AlertPolicy$Condition$ConditionCase: Removed field CONDITION_TIME_SERIES_QUERY_LANGUAGE [ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition removed [ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder removed [ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed [ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed ``` Committer: @miraleung PiperOrigin-RevId: 311581003 Source-Author: Google APIs <[email protected]> Source-Date: Thu May 14 12:13:51 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 123873dc7e2be35252d172205f67a375e70e9747 Source-Link: googleapis/googleapis@123873d * fix: restore GAPIC v2 retry configs Restores GAPIC v2 retry config overrides that were mistakenly removed during migration. PiperOrigin-RevId: 312088359 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 08:57:12 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c Source-Link: googleapis/googleapis@5a90d46 * feat(v1p3beta1): added support for streaming automl action recognition. PiperOrigin-RevId: 312101156 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 10:04:40 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: d1a9f02fd4fb263bae0383b4a5af0bbef33753d6 Source-Link: googleapis/googleapis@d1a9f02 * fix: point artman at gapic v1 for monitoring/v3 API Committer: @miraleung PiperOrigin-RevId: 312104480 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 10:19:39 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e94ad376529fabdfd2fce00407926a0cefd38b9e Source-Link: googleapis/googleapis@e94ad37 * Dialogflow weekly v2 library update: - Minor comment updates. PiperOrigin-RevId: 312123588 Source-Author: Google APIs <[email protected]> Source-Date: Mon May 18 11:49:18 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: cd3ce2651c3921670217e664303976cdf76e9fe2 Source-Link: googleapis/googleapis@cd3ce26 * chore(python): remove one remaining extra bash line (#565) To avoid generating bogus PRs Co-authored-by: Jeffrey Rennie <[email protected]> Source-Author: Carlos de la Guardia <[email protected]> Source-Date: Tue May 19 11:57:19 2020 -0500 Source-Repo: googleapis/synthtool Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e Source-Link: googleapis/synthtool@d2364eb * Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings. PiperOrigin-RevId: 312689208 Source-Author: Google APIs <[email protected]> Source-Date: Thu May 21 10:00:47 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f Source-Link: googleapis/googleapis@dec3204 * bazel: update protobuf, rules_go, gazelle, and gapic-generator-go versions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1 PiperOrigin-RevId: 313460921 Source-Author: Google APIs <[email protected]> Source-Date: Wed May 27 14:10:16 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: c4e37010d74071851ff24121f522e802231ac86e Source-Link: googleapis/googleapis@c4e3701 * Use correct resource type for DetachSubscriptionRequest PiperOrigin-RevId: 313488995 Source-Author: Google APIs <[email protected]> Source-Date: Wed May 27 16:45:32 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: eafa840ceec23b44a5c21670288107c661252711 Source-Link: googleapis/googleapis@eafa840 * docs: update python docs template (#576) * docs: update python docs template * sphinx change Source-Author: kolea2 <[email protected]> Source-Date: Wed May 27 20:44:34 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 71b8a272549c06b5768d00fa48d3ae990e871bec Source-Link: googleapis/synthtool@71b8a27 * feat: add templates for python samples projects (#506) These templates will be used for templates in python-docs-samples and in Python client libraries. The README generation code is a modified version of https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/scripts/readme-gen. Co-authored-by: Kurtis Van Gent <[email protected]> Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 14:39:58 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: ffe10407ee2f261c799fb0d01bf32a8abc67ed1e Source-Link: googleapis/synthtool@ffe1040 * chore: update default ignores for Python libraries (#586) Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 14:43:37 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: e99975b6b49827b8720f0a885e218dbdb67849ca Source-Link: googleapis/synthtool@e99975b * feat: allow custom python versions in noxfile (#585) Libraries on the microgenerator support a smaller range of Python versions (3.6+). Source-Author: Bu Sun Kim <[email protected]> Source-Date: Thu May 28 18:22:04 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 4e1d2cb79b02d7496b1452f91c518630c207145e Source-Link: googleapis/synthtool@4e1d2cb * docs: fix docs Co-authored-by: Bu Sun Kim <[email protected]>

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2020

software-dov reviewed Apr 27, 2020

View reviewed changes

software-dov self-requested a review April 28, 2020 18:55

vam-google added 6 commits April 30, 2020 15:07

set LC_ALL to fix kokoro build

1172bba

Merge remote-tracking branch 'upstream/master'

a72432d

Fix typo

bb5e605

add pyenv3_toolchain

8066385

add pyenv3_toolchain

6fae027

software-dov approved these changes May 4, 2020

View reviewed changes

add newline character

b69b8fc

vam-google merged commit d18ed41 into googleapis:master May 4, 2020

lukesneeringer pushed a commit to googleapis/googleapis that referenced this pull request May 4, 2020

Integrate Python GAPIC Microgenerator in googleapis.

e0f9d9e

This PR uses using documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146

This was referenced Jan 18, 2022

chore(master): release reverted #1133

Merged

chore(master): release 0.39.1 #1146

Closed

This was referenced Jan 26, 2022

chore(main): release 0.39.1 #1160

Closed

chore(main): release 0.39.1 #1162

Closed

chore(main): release 0.61.0 #1163

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Make GAPIC Bazel rules production ready #402

feat: Make GAPIC Bazel rules production ready #402

vam-google commented Apr 25, 2020 •

edited

Loading

vam-google commented Apr 25, 2020

software-dov left a comment

software-dov Apr 27, 2020

vam-google May 2, 2020

software-dov Apr 27, 2020

vam-google May 2, 2020 •

edited

Loading

software-dov Apr 27, 2020

software-dov commented Apr 29, 2020

vam-google commented Apr 30, 2020

vam-google commented May 2, 2020

software-dov left a comment

software-dov May 4, 2020

feat: Make GAPIC Bazel rules production ready #402

feat: Make GAPIC Bazel rules production ready #402

Conversation

vam-google commented Apr 25, 2020 • edited Loading

vam-google commented Apr 25, 2020

software-dov left a comment

Choose a reason for hiding this comment

software-dov Apr 27, 2020

Choose a reason for hiding this comment

vam-google May 2, 2020

Choose a reason for hiding this comment

software-dov Apr 27, 2020

Choose a reason for hiding this comment

vam-google May 2, 2020 • edited Loading

Choose a reason for hiding this comment

software-dov Apr 27, 2020

Choose a reason for hiding this comment

software-dov commented Apr 29, 2020

vam-google commented Apr 30, 2020

vam-google commented May 2, 2020

software-dov left a comment

Choose a reason for hiding this comment

software-dov May 4, 2020

Choose a reason for hiding this comment

vam-google commented Apr 25, 2020 •

edited

Loading

vam-google May 2, 2020 •

edited

Loading