Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: regenerate files from googleapis and synthtool templates #300

Merged
merged 17 commits into from
Jul 21, 2020
Merged

chore: regenerate files from googleapis and synthtool templates #300

merged 17 commits into from
Jul 21, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/572098f4-134f-4619-b579-f73c95c9fc4e/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 319105199
Source-Link: googleapis/googleapis@cbd6f1d
PiperOrigin-RevId: 318331819
Source-Link: googleapis/googleapis@0a602be
Source-Link: googleapis/synthtool@4f2c9f7
Source-Link: googleapis/synthtool@6d3eed6
PiperOrigin-RevId: 316514901
Source-Link: googleapis/googleapis@9b170a4
Source-Link: googleapis/synthtool@d1addcd
PiperOrigin-RevId: 316123861
Source-Link: googleapis/googleapis@66f959b
Source-Link: googleapis/synthtool@9872708
Source-Link: googleapis/synthtool@cac9eef
PiperOrigin-RevId: 314471006
Source-Link: googleapis/googleapis@d5fe42c
PiperOrigin-RevId: 313460921
Source-Link: googleapis/googleapis@c4e3701
PiperOrigin-RevId: 312088359
Source-Link: googleapis/googleapis@5a90d46
Source-Link: googleapis/synthtool@5b48b07
Source-Link: googleapis/synthtool@98c5077
Source-Link: googleapis/synthtool@55cdc84
PiperOrigin-RevId: 309824146
Source-Link: googleapis/googleapis@e0f9d9e

@yoshi-automation
Integrate Python GAPIC Microgenerator in googleapis. This PR uses usi…
b4f950a 
…ng documentai as an example. Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <[email protected]>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e
@yoshi-automation
ci(java): switch to GitHub Actions
ee31a6d 
* ci: switch to GitHub Actions

* update based on comment

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon May 11 12:54:00 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 55cdc844877d97139f25004229842624a6a86a02
Source-Link: googleapis/synthtool@55cdc84
@yoshi-automation
chore: move ci.yaml to workflows dir
5a0c7d9 
Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon May 11 16:24:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 98c50772ec23295c64cf0d2ddf199ea52961fd4c
Source-Link: googleapis/synthtool@98c5077
@yoshi-automation
docs: update CONTRIBUTING.md to include code formatting
a77e37b 
Co-authored-by: Jeff Ching <[email protected]>
Co-authored-by: Jeffrey Rennie <[email protected]>

Source-Author: Brian Chen <[email protected]>
Source-Date: Tue May 12 10:24:59 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5b48b0716a36ca069db3038da7e205c87a22ed19
Source-Link: googleapis/synthtool@5b48b07
@yoshi-automation
fix: restore GAPIC v2 retry configs
ac7ad47 
Restores GAPIC v2 retry config overrides that were
mistakenly removed during migration.

PiperOrigin-RevId: 312088359

Source-Author: Google APIs <[email protected]>
Source-Date: Mon May 18 08:57:12 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c
Source-Link: googleapis/googleapis@5a90d46
@yoshi-automation
bazel: update protobuf, rules_go, gazelle, and gapic-generator-go ver…
f033185 
…sions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1

PiperOrigin-RevId: 313460921

Source-Author: Google APIs <[email protected]>
Source-Date: Wed May 27 14:10:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c4e37010d74071851ff24121f522e802231ac86e
Source-Link: googleapis/googleapis@c4e3701
@yoshi-automation
firestore: add BatchWrite
c22a56a 
PiperOrigin-RevId: 314471006

Source-Author: Google APIs <[email protected]>
Source-Date: Tue Jun 2 22:32:52 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: d5fe42c39cd35f95131a0267314ae108ab1bef8d
Source-Link: googleapis/googleapis@d5fe42c
@yoshi-automation
chore: turn on renovate-bot master issue for java repos
6d420f3 
Source-Author: Stephanie Wang <[email protected]>
Source-Date: Thu Jun 4 18:23:16 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: cac9eef310652bf138dd76b716e4986e757d62ac
Source-Link: googleapis/synthtool@cac9eef
@yoshi-automation
build(java): skip lint on samples directory
29ab6b6 
Let the samples test decide how to enforce linting

Source-Author: Jeff Ching <[email protected]>
Source-Date: Fri Jun 5 13:40:10 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 987270824bd26f6a8c716d5e2022057b8ae7b26e
Source-Link: googleapis/synthtool@9872708
@yoshi-automation
chore: set Ruby namespace in proto options
da74ca0 
PiperOrigin-RevId: 316123861

Source-Author: Google APIs <[email protected]>
Source-Date: Fri Jun 12 10:03:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 66f959b51c255dd6bef79ef221865e53a50df878
Source-Link: googleapis/googleapis@66f959b
@yoshi-automation
ci(java): switch to secret manager from keystore
fd6d4b3 
* ci(java): switch to secret manager from keystore, use java-docs-samples user for samples tests

* fix: we don't need to supply a service account

Source-Author: Jeff Ching <[email protected]>
Source-Date: Mon Jun 15 11:45:21 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: d1addcdf80aa9ddef8c932c89c919024bbad7af3
Source-Link: googleapis/synthtool@d1addcd
@yoshi-automation
feat: retry CommitRequests that fail with UNAVAILABLE
6c18452 
PiperOrigin-RevId: 316514901

Source-Author: Google APIs <[email protected]>
Source-Date: Mon Jun 15 12:00:19 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 9b170a4f3beb16f7dab513520a07be48fcb88670
Source-Link: googleapis/googleapis@9b170a4
@yoshi-automation
samples(java): fix bad character in samples.cfg from copy/paste
13439c7 
Somehow an invisible character was copy/pasted into the file and Kokoro
cannot parse the file.

Source-Author: Jeff Ching <[email protected]>
Source-Date: Mon Jun 15 15:42:10 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 6d3eed67a45fd58f9c7bfa173c32e4fd4fed058f
Source-Link: googleapis/synthtool@6d3eed6
@yoshi-automation
ci(java): run dependency test on Java 8 and 11
0d5244e 
Redo fix in #633 with proper jinja templating format

Source-Author: Jeff Ching <[email protected]>
Source-Date: Fri Jun 19 16:52:15 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4f2c9f752a94042472fc03c5bd9e06e89817d2bd
Source-Link: googleapis/synthtool@4f2c9f7
@yoshi-automation
firestore: add BatchWrite to service config
ec1afe9 
PiperOrigin-RevId: 318331819

Source-Author: Google APIs <[email protected]>
Source-Date: Thu Jun 25 13:02:29 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 0a602be7b3835b51d59daf8f6f5dc2dc22f69d7e
Source-Link: googleapis/googleapis@0a602be
@yoshi-automation
firestore: add BatchWrite to gapic yaml
1e01e65 
PiperOrigin-RevId: 319105199

Source-Author: Google APIs <[email protected]>
Source-Date: Tue Jun 30 14:56:36 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: cbd6f1d28bc0c461c234f9848bcbc1563126daf9
Source-Link: googleapis/googleapis@cbd6f1d
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2020
@BenWhitehead BenWhitehead mentioned this pull request Jul 21, 2020
Closed
1 task
@BenWhitehead BenWhitehead changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. chore: regenerate files from googleapis and synthtool templates Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020 •
edited
Loading

Codecov Report

Merging #300 into master will increase coverage by 0.24%.
The diff coverage is 86.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
+ Coverage     73.38%   73.62%   +0.24%     
- Complexity     1050     1069      +19     
============================================
  Files            64       64              
  Lines          5669     5786     +117     
  Branches        646      645       -1     
============================================
+ Hits           4160     4260     +100     
- Misses         1302     1318      +16     
- Partials        207      208       +1
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/firestore/v1/FirestoreSettings.java 15.78% <0.00%> (-1.20%) 4.00 <0.00> (ø)
.../google/cloud/firestore/v1/stub/FirestoreStub.java 5.26% <0.00%> (-0.99%) 1.00 <0.00> (ø)
...cloud/firestore/v1/stub/FirestoreStubSettings.java 82.30% <82.92%> (-0.05%) 25.00 <2.00> (+2.00) ⬇️
...com/google/cloud/firestore/v1/FirestoreClient.java 82.92% <90.90%> (+1.73%) 40.00 <4.00> (+4.00)
...gle/cloud/firestore/v1/stub/GrpcFirestoreStub.java 96.60% <97.82%> (+0.20%) 22.00 <2.00> (+2.00)
.../firestore/v1/stub/FirestoreAdminStubSettings.java 86.73% <100.00%> (+0.13%) 23.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b3705...3048ad9. Read the comment docs.

@BenWhitehead
Copy link
Collaborator

@schmidt-sebastian Can you review the code generation about the Partition API?

@thebrianchen Can you review the code generation about the new BatchWriter?

Once I have approval from both of you I'll merge this, and then we should be able to start resolving merge conflicts for the outstanding PRs

schmidt-sebastian
schmidt-sebastian approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is LGTM

thebrianchen
thebrianchen approved these changes Jul 21, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BatchWrite code LGTM

@BenWhitehead BenWhitehead merged commit 0c841f9 into master Jul 21, 2020
@BenWhitehead BenWhitehead deleted the autosynth branch July 21, 2020 21:45
@BenWhitehead BenWhitehead mentioned this pull request Jul 21, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@thebrianchen thebrianchen thebrianchen approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @BenWhitehead @thebrianchen @schmidt-sebastian