Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java [9, ...) builds were broken but not picked up by tests #280

Closed
olavloite opened this issue Jun 18, 2020 · 0 comments · Fixed by #345 or #348
Closed

Java [9, ...) builds were broken but not picked up by tests #280

olavloite opened this issue Jun 18, 2020 · 0 comments · Fixed by #345 or #348
Assignees
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: process A process-related concern. May include testing, release, or the like.

Comments

@olavloite
Copy link
Collaborator

Java 9 and higher builds were broken by the maven-flatten-plugin because of this profile in the pom:

    <profile>
      <id>java9</id>
      <activation>
        <jdk>[9,)</jdk>
      </activation>
      <dependencies>
        <dependency>
          <groupId>javax.annotation</groupId>
          <artifactId>javax.annotation-api</artifactId>
          <version>1.3.2</version>
        </dependency>
      </dependencies>
    </profile>

This breakage does not seem to have been picked up by the (samples) tests, while it did break the samples once those were updated to the latest version of the Spanner client. These kinds of errors should be detected by the tests in the client library.

See also GoogleCloudPlatform/java-docs-samples#3182

@olavloite olavloite added the type: process A process-related concern. May include testing, release, or the like. label Jun 18, 2020
@olavloite olavloite self-assigned this Jun 18, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jun 18, 2020
@olavloite olavloite changed the title Java [9, ...> builds were broken but not picked up by tests Java [9, ...) builds were broken but not picked up by tests Jun 18, 2020
ansh0l pushed a commit to ansh0l/java-spanner that referenced this issue Nov 10, 2022
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this issue Nov 17, 2022
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/5b6c114a-8bee-4a8e-8985-0e8ec5df74d0/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@943bb78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
1 participant