-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: also test deps on Java 11 #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Note that ci.yaml and dependencies.sh are managed by templates here and will be overwritten the next run. Since it looks like it works, can we make those changes upstream?
@olavloite I'll leave this up to you to merge since I don't know which parts of this will be done by the bot. |
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, autotogen will update the corresponding CL at gocloud to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs and CLs once per night. If you have been assigned to review this CL, please: - Ensure that CI is passin If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt gapicgen to assign reviewers to the gocloud CL. Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/49750
Run dependency test on both Java 8 and Java 11, as some dependencies are only included in Java versions 9 and higher.
Towards #280 and GoogleCloudPlatform/java-docs-samples#3182