feature: Adding CollectionGroup queries #578
Conversation
googlebot
added
the
cla: yes
schmidt-sebastian
changed the title
schmidt-sebastian
added
status: blocked
schmidt-sebastian
force-pushed
the
mrschmidt-collectiongroup
branch
from
4d4ff12
to
9fae4c7
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-collectiongroup
branch
from
9fae4c7
to
b2d9fb2
Compare
schmidt-sebastian
force-pushed
the
mrschmidt-collectiongroup
branch
from
b2d9fb2
to
9498764
Compare
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 95.73% 95.66% -0.07%
==========================================
Files 24 24
Lines 1969 1984 +15
Branches 167 167
==========================================
+ Hits 1885 1898 +13
- Misses 63 64 +1
- Partials 21 22 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
======================================
Coverage 55.1% 55.1%
======================================
Files 5 5
Lines 274 274
======================================
Hits 151 151
Misses 123 123Continue to review full report at Codecov.
|
| readonly parentPath: ResourcePath, readonly collectionId: string, | ||
| readonly allDescendants: boolean, readonly fieldFilters: FieldFilter[], | ||
| readonly fieldOrders: FieldOrder[], readonly startAt?: QueryCursor, | ||
| readonly endAt?: QueryCursor, readonly limit?: number, |
There was a problem hiding this comment.
It looks like startAfter and endBefore were omitted, what is the reason? Looks like they were unused previously?
There was a problem hiding this comment.
This is actually meant to mimic the proto, where startAfter and endBefore are just different settings in the QueryCurso (startAt sets before to true, whereas startAfter sets it to false).
|
I'm really sorry, I somehow managed to miss this PR entirely. I usually respond no later than the next day on code reviews; feel free to ping me if I don't. |
schmidt-sebastian
changed the title
schmidt-sebastian
removed
do not merge
CollectionGroup queries add support for queries to Firestore that query documents by collection ID rather than by collection path. With this feature, users can now query for documents in collections that share a name, no matter where these collection are located.
This the Node port of googleapis/google-cloud-java#4652. The integration tests are ported from firebase/firebase-js-sdk#1440
Note: This PR is blocked on a backend release.