Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore Collection Group queries #3416

Merged
merged 2 commits into from
May 29, 2019

Conversation

quartzmo
Copy link
Member

Collection Group queries add support for queries to Firestore that query documents by collection ID rather than by collection path. With this feature, users can now query for documents in collections that share a name, no matter where these collection are located.

Java: googleapis/google-cloud-java#4652
Node: googleapis/nodejs-firestore#578
Python: googleapis/google-cloud-python#7758

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2019
@quartzmo quartzmo added the api: firestore Issues related to the Firestore API. label May 24, 2019
@quartzmo quartzmo self-assigned this May 28, 2019
@quartzmo
Copy link
Member Author

/cc @schmidt-sebastian

@quartzmo quartzmo force-pushed the firestore-collection-group branch from 213e042 to c53c68f Compare May 28, 2019 16:23
@quartzmo
Copy link
Member Author

Rebased on master for build fix (#3417).

Copy link

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 25 lines of core logic is probably the new record for a new Firestore feature!

@quartzmo
Copy link
Member Author

@crwilcox Good to merge?

@quartzmo quartzmo merged commit f5ab826 into googleapis:master May 29, 2019
@quartzmo quartzmo deleted the firestore-collection-group branch May 29, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants