Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower default publisher maxMillseconds value #97

Merged
merged 1 commit into from
Mar 14, 2018
Merged

lower default publisher maxMillseconds value #97

merged 1 commit into from
Mar 14, 2018

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Mar 14, 2018 •
edited
Loading

Fixes #96

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@codecov
Copy link

codecov bot commented Mar 14, 2018 •
edited
Loading

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         848    848           
=====================================
  Hits          848    848
Impacted Files Coverage Δ
src/publisher.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e6b83...ee9a64c. Read the comment docs.

@callmehiphop callmehiphop merged commit a981688 into googleapis:master Mar 14, 2018
@callmehiphop callmehiphop mentioned this pull request Mar 19, 2018
Merged
stephenplusplus pushed a commit to stephenplusplus/nodejs-pubsub that referenced this pull request Aug 31, 2018
@JustinBeckwith @alexander-fenster
refactor: drop repo-tool as an exec wrapper (googleapis#97)
2200ec0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callmehiphop @stephenplusplus