Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower default publisher maxMillseconds value #97

Merged
merged 1 commit into from
Mar 14, 2018
Merged

lower default publisher maxMillseconds value #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/publisher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ var is = require('is');
* @param {number} [options.batching.maxMessages] The maximum number of messages
* to buffer before sending a payload.
* @param {number} [options.batching.maxMilliseconds] The maximum duration to
* wait before sending a payload.
* wait before sending a payload. Defaults to 100 milliseconds.
*
* @example
* const PubSub = require('@google-cloud/pubsub');
Expand All @@ -57,7 +57,7 @@ function Publisher(topic, options) {
batching: {
maxBytes: Math.pow(1024, 2) * 5,
maxMessages: 1000,
maxMilliseconds: 1000,
maxMilliseconds: 100,
},
},
options
Expand Down
2 changes: 1 addition & 1 deletion test/publisher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ describe('Publisher', function() {
assert.deepEqual(publisher.settings.batching, {
maxBytes: Math.pow(1024, 2) * 5,
maxMessages: 1000,
maxMilliseconds: 1000,
maxMilliseconds: 100,
});
});

Expand Down