This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
chore(samples): use timezone aware datetimes #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: cloudtrace
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
engelke
approved these changes
Aug 17, 2021
| @@ -29,7 +29,7 @@ def batch_write_spans(project_id: str): | |||
| trace_id = str(uuid.uuid4()).replace("-", "") | |||
| span_id = str(uuid.uuid4()).replace("-", "")[:16] | |||
|
|
|||
| end_time = datetime.datetime.now() | |||
| end_time = datetime.datetime.now(tz=datetime.timezone.utc) | |||
There was a problem hiding this comment.
This is fine. You could also have replaced the old datetime.now() with datetime.utcnow().
busunkim96
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GoogleCloudPlatform/python-docs-samples#6581