docs: require timezone aware datetimes #6581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
google-cla
bot
added
the
cla: yes
dandhlee
approved these changes
Aug 17, 2021
leahecole
approved these changes
Aug 17, 2021
|
Now I'm curious about what kinds of mayhem not doing this can cause 😁 |
leahecole
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
|
There's a DATETIME data type in BigQuery that's specifically not timezone-aware, but I still think this makes sense as general advice when not dealing with a data type where it doesn't make sense. |
tswast
reviewed
Aug 17, 2021
|
|
||
| Always create timezone aware datetime objects. For libraries that use protobuf, | ||
| omitting the timezone may lead to unexpected behavior when the datetime | ||
| is converted to a protobuf tiemstamp. |
There was a problem hiding this comment.
Suggested change
| is converted to a protobuf tiemstamp. | |
| is converted to a protobuf timestamp. |
This was referenced Aug 17, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/python-trace
that referenced
this pull request
Aug 31, 2021
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to discussion in googleapis/python-tasks#147 (comment).
If this is an OK blanket recommendation to make, I will follow up with a PR to adjust all the calls to
datetime.datetimein this repository.For supporting documentation, see warnings for these two methods: