Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Remove Python 2.7 from templates #1118

Closed
anguillanneuf opened this issue Jun 16, 2021 · 0 comments · Fixed by #1173
Closed

[Python] Remove Python 2.7 from templates #1118

anguillanneuf opened this issue Jun 16, 2021 · 0 comments · Fixed by #1173
Assignees
@parthea
Labels
lang: python Issues specific to Python. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@anguillanneuf
Copy link

It's probably safe to remove 2.7 support for all libraries now?

synthtool/synthtool/gcp/templates/python_samples/noxfile.py.j2

Line 91 in bb5ef5a

ALL_VERSIONS = ["2.7", "3.6", "3.7", "3.8", "3.9"]

@anguillanneuf anguillanneuf mentioned this issue Jun 16, 2021
Merged
@danoscarmike danoscarmike added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 16, 2021
@parthea parthea changed the title Remove Python 2.7 from noxfile.py [Python] Remove Python 2.7 from templates Jun 18, 2021
@parthea parthea added the lang: python Issues specific to Python. label Jun 18, 2021
@parthea parthea mentioned this issue Jun 18, 2021
Merged
@tseaver tseaver mentioned this issue Jun 18, 2021
Merged
@tseaver tseaver mentioned this issue Aug 1, 2021
Merged
tseaver added a commit that referenced this issue Aug 13, 2021
@tseaver @parthea
chore: drop mention of Python 2.7 from templates (#1173)
facee4c 
Install async test dependencies unconditionally.

Drop unused 'samples' session. Samples are tested via separate noxfiles in all repos which have them.

Closes #1118.

Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
lang: python Issues specific to Python. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: drop mention of Python 2.7 from templates
4 participants
@danoscarmike @parthea @anguillanneuf @SurferJeffAtGoogle