Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop mention of Python 2.7 from templates #1173

Merged
merged 8 commits into from
Aug 13, 2021
Merged

chore: drop mention of Python 2.7 from templates #1173

merged 8 commits into from
Aug 13, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 1, 2021

Closes #1118.

@tseaver tseaver requested a review from busunkim96 August 1, 2021 19:24
@tseaver tseaver requested a review from a team August 1, 2021 19:24
@tseaver tseaver requested a review from a team as a code owner August 1, 2021 19:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2021
@parthea parthea changed the title fix: drop mention of Python 2.7 from templates chore: drop mention of Python 2.7 from templates Aug 2, 2021
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations, otherwise LGTM.

synthtool/gcp/common.py Show resolved Hide resolved
synthtool/gcp/templates/python_library/noxfile.py.j2 Outdated Show resolved Hide resolved
synthtool/gcp/templates/python_samples/noxfile.py.j2 Outdated Show resolved Hide resolved
Co-authored-by: Anthonios Partheniou <[email protected]>
Reorder standard deps, external deps for clarity.
Samples are tested via separate noxfiles in all repos which have them.
@tseaver
Copy link
Contributor Author

tseaver commented Aug 5, 2021

Hmm, @parthea I'm surprised your review is not sufficient to allow a merge. Because I touched synthtool/gcp/common.py, which falls outside of the Python templates, it appears that I need one of the following approvals:

I would've expected that you were a member of @googleapis/github-automation.

@parthea
Copy link
Contributor

parthea commented Aug 9, 2021

@bcoe Please can you take a look for @googleapis/github-automation?

@tseaver tseaver assigned bcoe and unassigned tseaver Aug 10, 2021
@tseaver tseaver merged commit facee4c into googleapis:master Aug 13, 2021
tseaver pushed a commit to googleapis/python-compute that referenced this pull request Aug 16, 2021
m-strzelczyk pushed a commit to GoogleCloudPlatform/python-docs-samples that referenced this pull request Nov 9, 2022
dandhlee pushed a commit to GoogleCloudPlatform/python-docs-samples that referenced this pull request Nov 16, 2022
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Remove Python 2.7 from templates
3 participants