chore: Add check for tests in directory #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahecole
changed the title
leahecole
force-pushed
the
noxfile-check-for-tests
branch
from
b728fa7
to
c4218c2
Compare
leahecole
force-pushed
the
noxfile-check-for-tests
branch
from
c4218c2
to
0788566
Compare
busunkim96
approved these changes
Jan 11, 2022
leahecole
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 11, 2022
PR #1321 added `glob.glob` but the import statement was missing.
gcf-merge-on-green bot
pushed a commit
to GoogleCloudPlatform/python-docs-samples
that referenced
this pull request
Jan 11, 2022
This adds a check to the noxfile to see if there are tests in the directory. To test, use the noxfile-template in any directory with tests. Then try it on a directory like [this one](https://github.com/nikitamaia/python-docs-samples/tree/geospatial-sandbox/people-and-planet-ai/geospatial-classification/serving_app) which is found in PR #7291. This does assume that all tests are of the format `*_test.py` - if we want, I can also include a check for `test_*.py`, because I know that's a common Python pattern even though it's not the one we use. Corresponding PR in synthtool googleapis/synthtool#1321 cc @davidcavazos - this will hopefully remove the need for your workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GoogleCloudPlatform/python-docs-samples#7342 for more info