Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): fix undefined name 'glob' in samples noxfile #1324

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jan 11, 2022

PR #1321 added glob.glob but the import statement was missing.

@parthea parthea requested a review from a team as a code owner January 11, 2022 11:54
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 11, 2022
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that we caught this reasonably early

@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 52aef91 into master Jan 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-missing-import-noxfile branch January 11, 2022 12:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 11, 2022
@leahecole
Copy link
Contributor

Oh NO!!! I am so sorry. I caught it in the template in p-d-s but not here. Thank you SO MUCH @parthea !!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants