Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump norad and fea-rs #351

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Bump norad and fea-rs #351

merged 1 commit into from
Jun 29, 2023

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Jun 29, 2023

fixes some designspace and FEA parsing issues.

rsheeter
rsheeter approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@rsheeter rsheeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very minor nit: it would be nice to link to the PR/issues/we for the issues this fixes in the PR comment.

@cmyr
Copy link
Member Author

cmyr commented Jun 29, 2023

relevant:

#349
cmyr/fea-rs#170
linebender/norad#304

@cmyr cmyr merged commit 507e2e6 into main Jun 29, 2023
6 checks passed
@cmyr cmyr deleted the update-deps branch June 29, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsheeter rsheeter rsheeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @rsheeter