Required is more like a suggestion #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spec is wrong, fixed in fonttools/fonttools#3194 |
rsheeter
reviewed
Jun 29, 2023
| pub fn generate_missing_source_name() -> String { | ||
| static COUNTER: AtomicU64 = AtomicU64::new(0); | ||
| let next_n = COUNTER.fetch_add(1, std::sync::atomic::Ordering::Relaxed); | ||
| format!("unnamed_source_{next_n}") |
There was a problem hiding this comment.
Optional, we could match the existing authoritative implementation (https://github.com/fonttools/fonttools/blob/main/Lib/fontTools/designspaceLib/__init__.py#L2311), though I cannot think of a reason it would matter.
There was a problem hiding this comment.
this would be more annoying, since we don't have access to serde's internal state (and hence don't know the actual index of the current source) and so we would need to do a post-processing step to assign the names after loading the whole designspace. 🤷
rsheeter
reviewed
Jun 29, 2023
rsheeter
reviewed
Jun 29, 2023
rsheeter
reviewed
Jun 29, 2023
rsheeter
approved these changes
Jun 29, 2023
This updates DesignSpaceDocument to allow inputs where sources do not have names; we will autogenerate names if they are missing.
cmyr
force-pushed
the
optional-dspace-names
branch
from
43f6c95
to
f50b7e7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates DesignSpaceDocument to allow inputs where sources do not have names; we will autogenerate names if they are missing.