Define the proto definition for the allocator service #1025

pooneh-m · 2019-08-30T17:34:00Z

Define the v1alpha1 gRPC API protobuf definition for the allocator service according to the GameServerAllocation Extension API server.
issue: #597

agones-bot · 2019-08-30T17:39:49Z

Build Failed 😱

Build Id: f93996f1-e4b3-4fa7-a76d-c771e4776340

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pooneh-m · 2019-08-30T19:21:29Z

Upgrading the protobuf package to fix the build error for proto3 dependency: #1027

markmandel

Looks like this issue is the linter is failing on the generated code. I think you will need to have a line "This code was autogenerated. Do not edit directly." - which is included in https://github.com/googleforgames/agones/blob/master/build/boilerplate.go.txt

May be easier to get all the make commands working in this PR?

markmandel · 2019-09-03T16:45:39Z

cmd/allocator/v1alpha1/allocation.pb.go

@@ -0,0 +1,539 @@
+// Code generated by protoc-gen-go. DO NOT EDIT.


This will need a licence header as well. We have examples in the sdk gen tooling on how we did this.

Looks like this issue is the linter is failing on the generated code. I think you will need to have a line "This code was autogenerated. Do not edit directly." - which is included in https://github.com/googleforgames/agones/blob/master/build/boilerplate.go.txt

May be easier to get all the make commands working in this PR?

Thanks, yes I am working on the make commands. Will update this PR when done.

agones-bot · 2019-09-03T23:02:07Z

Build Failed 😱

Build Id: 53546aba-8738-4c69-ba4d-77c7ca812182

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-04T06:53:08Z

Build Failed 😱

Build Id: 0cd0daef-cc21-4031-a64c-f1614ea55be9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-09-04T20:05:54Z

Just checking this is good for review - happy to do so, but noticed it's been pared back to just the proto. Wasn't sure if more was coming.

pooneh-m · 2019-09-04T20:16:14Z

To keep the reviews focused, I broke down the PR to two, one for the proto and one for the generated code and the scripts for code generation. I'll send the latter PR by the end of today.

markmandel

Approved!

I'd prefer it without that TODO 😄 , for reasons outlined below, but if you want to leave it in, merge away! 👍

cmd/allocator/v1alpha1/allocation.proto

google-oss-robot · 2019-09-04T23:13:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, pooneh-m
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-09-04T23:13:06Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-09-04T23:28:54Z

Build Succeeded 👏

Build Id: e2d99487-262a-4f52-8718-ccfa0dd4e97a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-c620106
image: gcr.io/agones-images/agones-sdk:1.0.0-c620106
image: gcr.io/agones-images/agones-ping:1.0.0-c620106
Linux C++ SDK (build): agonessdk-1.0.0-c620106-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-c620106.zip

A preview of the website (the last 30 builds are retained):

https://c620106-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1025/head:pr_1025 && git checkout pr_1025
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-c620106

…o the gameserverallocation Extention API server.

agones-bot · 2019-09-05T06:28:26Z

Build Succeeded 👏

Build Id: ab726cdb-362c-4e7a-b577-4a5ef71193ab

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-a39df5b
image: gcr.io/agones-images/agones-sdk:1.0.0-a39df5b
image: gcr.io/agones-images/agones-ping:1.0.0-a39df5b
Linux C++ SDK (build): agonessdk-1.0.0-a39df5b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-a39df5b.zip

A preview of the website (the last 30 builds are retained):

https://a39df5b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1025/head:pr_1025 && git checkout pr_1025
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-a39df5b

google-oss-robot added the size/XL label Aug 30, 2019

markmandel reviewed Sep 3, 2019

View reviewed changes

pooneh-m force-pushed the grpc branch from 6377e65 to 61b1e71 Compare September 3, 2019 22:19

google-oss-robot added size/M and removed size/XL labels Sep 3, 2019

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones and removed area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Sep 4, 2019

markmandel approved these changes Sep 4, 2019

View reviewed changes

cmd/allocator/v1alpha1/allocation.proto Show resolved Hide resolved

cmd/allocator/v1alpha1/allocation.proto Outdated Show resolved Hide resolved

google-oss-robot assigned markmandel Sep 4, 2019

google-oss-robot added the lgtm label Sep 4, 2019

google-oss-robot removed the lgtm label Sep 4, 2019

Define the v1alpha1 proto definition of the allocator API according t…

a39df5b

…o the gameserverallocation Extention API server.

pooneh-m force-pushed the grpc branch from c620106 to a39df5b Compare September 5, 2019 06:12

pooneh-m merged commit acaccf0 into googleforgames:master Sep 5, 2019

pooneh-m deleted the grpc branch September 6, 2019 17:24

markmandel added this to the 1.0.0 milestone Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define the proto definition for the allocator service #1025

Define the proto definition for the allocator service #1025

pooneh-m commented Aug 30, 2019 •

edited

Loading

agones-bot commented Aug 30, 2019

pooneh-m commented Aug 30, 2019 •

edited

Loading

markmandel left a comment

markmandel Sep 3, 2019

pooneh-m Sep 3, 2019

agones-bot commented Sep 3, 2019

agones-bot commented Sep 4, 2019

markmandel commented Sep 4, 2019

pooneh-m commented Sep 4, 2019

markmandel left a comment

google-oss-robot commented Sep 4, 2019

google-oss-robot commented Sep 4, 2019

agones-bot commented Sep 4, 2019

agones-bot commented Sep 5, 2019

		@@ -0,0 +1,539 @@
		// Code generated by protoc-gen-go. DO NOT EDIT.

Define the proto definition for the allocator service #1025

Define the proto definition for the allocator service #1025

Conversation

pooneh-m commented Aug 30, 2019 • edited Loading

agones-bot commented Aug 30, 2019

pooneh-m commented Aug 30, 2019 • edited Loading

markmandel left a comment

Choose a reason for hiding this comment

markmandel Sep 3, 2019

Choose a reason for hiding this comment

pooneh-m Sep 3, 2019

Choose a reason for hiding this comment

agones-bot commented Sep 3, 2019

agones-bot commented Sep 4, 2019

markmandel commented Sep 4, 2019

pooneh-m commented Sep 4, 2019

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Sep 4, 2019

google-oss-robot commented Sep 4, 2019

agones-bot commented Sep 4, 2019

agones-bot commented Sep 5, 2019

pooneh-m commented Aug 30, 2019 •

edited

Loading

pooneh-m commented Aug 30, 2019 •

edited

Loading