Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf go package dependency to v3 #1027

Closed
wants to merge 1 commit into from

Conversation

pooneh-m
Copy link
Contributor

Upgrade go package dependency to 1.3.2 for golang/protobuf in go.mod and ran go mod vendor.
The additional changes to pborman/uuid are due to outdated vendor.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pooneh-m
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e3b80d01-d46a-4365-92e1-1565f39e3c95

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1027/head:pr_1027 && git checkout pr_1027
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-c117e18

@pooneh-m pooneh-m changed the title Upgrade protobuf go dependency to support proto3 Upgrade protobuf go package dependency to v3 Aug 30, 2019
@markmandel
Copy link
Member

The previous go protoc package (1.2.0) supported proto 3, so I'm not sure why we are upgrading? Is there a strong reason to do so?

Given that were aiming for 1.0 in the next release, I'm thinking we shouldn't do this to maintain a stable, known system, unless there is a very good reason to do this?

@pooneh-m
Copy link
Contributor Author

Makes sense. I am introducing an allocator API proto definition and getting dependency to the latest proto package, but it is not necessary.

@pooneh-m pooneh-m closed this Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants