-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trip Functionality #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n passing in as props.
Merged
…he test or immediately following any test constants (such as the test input) it includes.
anan-ya-y
approved these changes
Jul 17, 2020
keiffer01
requested changes
Jul 17, 2020
keiffer01
reviewed
Jul 17, 2020
zghera
commented
Jul 17, 2020
month: 'long', | ||
day: 'numeric', | ||
hour: 'numeric', | ||
minute: '2-digit', | ||
timeZone: timezone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were automatically made by VSCode and I am don't know if its worth the time of going into vim and manually changing it back in each branch.
keiffer01
approved these changes
Jul 17, 2020
HiramSilvey
requested changes
Jul 20, 2020
HiramSilvey
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Adds functionality to clean the data entered in the add trip modal before creating a new Trip document in Firestore.
Is this fixing an issue?
fixes #43: Address the portions of clean/format the data and create a new Trip document in the database.
progress on #47: All Trip documents created in Firestore contain the required fields specified in the design doc. However it still may be beneficial to implement the Firebase security rules in a future PR.
fixes #52: Created form control types for collaborators and dates fields.
Are there more details that are relevant?
The main addition of this PR is to the following files:
index.js
:refreshTripContainer
that is passed in as a prop to TripsContainer to update the trips container for the current user whenever a new trip is submitted. In the future, the use ofrefreshTripContainer
and the key prop on Trips container should be removed with the addition of real time listening with onShapshot (Issue Implement Real Time Updates for all Trip Collaborators #62).refreshAddTripModal
that is passed as prop to AddTripModal to refresh the component whenever it is opened. This is to prevent the issue where multiple collaborator text boxes persist between closing and re-opening the modal.add-trip.js
(changed toadd-trip-modal.js
PR Rename add-trip.js to add-trip-modal.js. #68):filter-input.js
: Contains functions for sanitizing and formatting form input data. This file will also be the home of the email verification (Email Verification for Add Trip #67) implemented when implemented.Additionally, Auth hardcoded functions were moved into a temporary file
temp-auth-utils.js
in Utils where they are imported in relevant filed rather than passing in these values/props in from ViewTrips component. These import will be updated with the real auth utils once that module is completed.Check lists (check
x
in[ ]
of list items)As of now, integration (end-to-end) tests were deemed non-critical. Thus, functions related to react and firestore will be tested at a later time. Unit tests for "logical" functions will be included in this PR and for the remaining PRs needed to complete the MVP.
Any additional comments?
Gif showing functionality: