feat(rpm): support %config(missingok)

[caarlos0]

closes #853

[cloudflare-workers-and-pages]

Deploying nfpm with    Cloudflare Pages

Latest commit:	4e1d1d0
Status:	⚡️  Build in progress...

View logs

[robsliwi]

Somehow dnf running on AlmaLinux 8.10 is still complaining with a warning, though.
fav32.png is a config|missingok and grafana_icon.svg is a config|noreplace in a little Toy example:

Running transaction
  Preparing        :                                                                                                    1/1
  Erasing          : grafana-re-configuration-0.0.1-1.x86_64                                                            1/1
warning: file /tmp/grafana_icon.svg: remove failed: No such file or directory
warning: file /tmp/fav32.png: remove failed: No such file or directory
                                                                                                                            
  Verifying        : grafana-re-configuration-0.0.1-1.x86_64                                                            1/1
                                                                                                                            
Removed:
  grafana-re-configuration-0.0.1-1.x86_64

I will try to reproduce the toy example with a classic specfile and see if dnf complains with the warning here, too. But what for sure is possible with the specfile is to combine missingok and noreplace in a %config(missingok,noreplace) directive.

Was pleasantly surprised that direnv was asking me to allow the Nix devShell after checking out the repo 👍

[robsliwi]

Small follow-up:

I will try to reproduce the toy example with a classic specfile and see if dnf complains with the warning here, too.

I did with the following spec file:

[root@d3d1a05f3904 ~]# cat hello.spec
Name:       hello-world
Version:    1
Release:    1
Summary:    Lets see if we can make it missingok
License:    FIXME
                                                                                                        
%description
This is my first RPM package, which does nothing.
                                                                                                        
%build
cat > config.conf <<EOF
# some config
EOF
                                                                                                        
%install
mkdir -p %{buildroot}/tmp/
install -m 755 config.conf %{buildroot}/tmp/config.conf
                                                                                                        
%files
%config(missingok) /tmp/config.conf
                                                                                                        
%changelog
# let's skip this for now

And the removal of the build RPM with a missing/moved /tmp/config.conf:

[root@d3d1a05f3904 ~]# mv /tmp/config.conf /tmp/config.conf.moved
mv: overwrite '/tmp/config.conf.moved'? y
[root@d3d1a05f3904 ~]# dnf remove hello-world
Dependencies resolved.
========================================================================================================
 Package                    Architecture          Version            Repository                    Size
========================================================================================================
Removing:
 hello-world                x86_64                1-1                @@commandline                 14
                                                                                                        
Transaction Summary
========================================================================================================
Remove  1 Package
                                                                                                        
Freed space: 14
Is this ok [y/N]: y
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                1/1
  Erasing          : hello-world-1-1.x86_64                                                         1/1
  Verifying        : hello-world-1-1.x86_64                                                         1/1
                                                                                                        
Removed:
  hello-world-1-1.x86_64
                                                                                                        
Complete!

No warnings here. Is there some place where I could have a peak at the generated spec file before "building" the RPM in the source code?

[caarlos0]

we don't create a spec file, that's why you don't need to have rpm installed to use this.

that said, I double checked https://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/pkgformat.html#AEN27560 and google/rpmpack (which we use) and everything seems correct...

maybe its a bug on rpmpack? not sure yet

[robsliwi]

Just went through the examples and verified the file flags and those were set correctly.

rpm -qp --qf '[%{FILENAMES} %{FILEFLAGS:fflags}\n]' example-0.0.1-1.x86_64.rpm
/tmp/fav32.png cm
/tmp/grafana_icon.svg cn

And dnf is happy with all missing files with the newly introduced cn file flag 📦 🎉

Thanks a lot for the blazing fast implementation!

The duplicated line is fine?