Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeviceProvider to get multiple devices at once #1112

Closed
wants to merge 1 commit into from

Conversation

haoxli
Copy link
Contributor

@haoxli haoxli commented Mar 28, 2022

  • Update DeviceProvider could provide multiple devices at once, for devices
    with same descriptor, they will be held by same DeviceHolder.
  • Remove selectMismatchedDeviceOrSkipTestCase helper.

Issue: #912


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

Previews, as seen when this build job started (826b8b4):
Run tests | View tsdoc

@haoxli haoxli marked this pull request as draft March 28, 2022 06:56
@haoxli haoxli force-pushed the 912-update-mismatched-device branch from 826b8b4 to 23d3d48 Compare April 1, 2022 15:16
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Previews, as seen when this build job started (23d3d48):
Run tests | View tsdoc

@haoxli haoxli force-pushed the 912-update-mismatched-device branch from 23d3d48 to f033dc3 Compare April 5, 2022 15:57
@haoxli haoxli closed this Apr 5, 2022
@haoxli haoxli deleted the 912-update-mismatched-device branch April 5, 2022 16:03
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Previews, as seen when this build job started (f033dc3):
Run tests | View tsdoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant