Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecated .sampleType/.copySrc from kTextureFormatInfo #3394

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Feb 13, 2024

Verified:

All the other changes should be trivial enough that there isn't danger of breaking anything. Hopefully.

Part 5 of Issue: #2495


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x force-pushed the textureinfo2part5 branch 3 times, most recently from 5c0f693 to f69a102 Compare February 13, 2024 22:34
@kainino0x kainino0x changed the title Clean up deprecated fields from kTextureFormatInfo Clean up deprecated .sampleType/.copySrc from kTextureFormatInfo Feb 13, 2024
@kainino0x kainino0x force-pushed the textureinfo2part5 branch 2 times, most recently from 0c8e1b8 to 3437c24 Compare February 15, 2024 00:47
@kainino0x kainino0x marked this pull request as ready for review February 15, 2024 00:47
@kainino0x
Copy link
Collaborator Author

@lokokung PTAL (not sure if you get notified when I just request a review)

@kainino0x
Copy link
Collaborator Author

Fixed merge conflict in latest commit.

@kainino0x kainino0x enabled auto-merge (rebase) February 16, 2024 17:39
@kainino0x kainino0x force-pushed the textureinfo2part5 branch 2 times, most recently from 86a2150 to f4895ca Compare February 16, 2024 17:43
@kainino0x kainino0x enabled auto-merge (rebase) February 16, 2024 17:43
@kainino0x kainino0x merged commit b895d84 into gpuweb:main Feb 16, 2024
1 check passed
@kainino0x kainino0x deleted the textureinfo2part5 branch February 16, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants