Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace graal-sdk with nativeimage, word, and collections #358

Closed
wants to merge 1 commit into from

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Aug 17, 2023

Package was split in oracle/graal#7171

Depends on oracle/graal#7205

@zakkak zakkak added this to the 23.1.0.0-Final milestone Aug 17, 2023
@zakkak zakkak requested a review from jerboaa August 17, 2023 11:13
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 17, 2023
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implicitly will no longer build graal-sdk, which is the only GraalVM dependency in Quarkus. We need to carefully look at what dependencies we need to replace this with on the Quarkus end. Also affects graal-sdk not being built with --java-only which affects the product build.

@zakkak
Copy link
Collaborator Author

zakkak commented Aug 17, 2023

This implicitly will no longer build graal-sdk, which is the only GraalVM dependency in Quarkus. We need to carefully look at what dependencies we need to replace this with on the Quarkus end. Also affects graal-sdk not being built with --java-only which affects the product build.

Good point, so before moving forward with this we need to see what the plans for the upstream graal-sdk maven artifact are. If it's indeed going to keep getting published as is we should not remove it from our builds.

Update: I created #359 as an alternative

@jerboaa
Copy link
Collaborator

jerboaa commented Aug 17, 2023

I'm thinking to go with this one for now and keep a close eye out on oracle/graal#7224 and do all necessary preparations to move to the new API maven artefact.

@jerboaa
Copy link
Collaborator

jerboaa commented Aug 21, 2023

On second thought, we might need to go with #359 after all so as to build graal-sdk which will be the dep Quarkus is currently using. It cannot be changed easily, since Quarkus wants to work with older GraalVM releases as well. So we might want to change to a slimmer build a few releases in the future only.

@jerboaa
Copy link
Collaborator

jerboaa commented Aug 21, 2023

This PR has the same problem when testing GRAAL_SDK local deployment as #359. See #359 (comment)

@jerboaa jerboaa marked this pull request as draft August 21, 2023 17:02
@zakkak
Copy link
Collaborator Author

zakkak commented Sep 5, 2023

superseded by #360

@zakkak zakkak closed this Sep 5, 2023
@zakkak zakkak deleted the 2023-08-17-new-modules branch September 5, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants