-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace graal-sdk with nativeimage, word, and collections #358
Conversation
Package was split in oracle/graal#7171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implicitly will no longer build graal-sdk, which is the only GraalVM dependency in Quarkus. We need to carefully look at what dependencies we need to replace this with on the Quarkus end. Also affects graal-sdk not being built with --java-only
which affects the product build.
Good point, so before moving forward with this we need to see what the plans for the upstream graal-sdk maven artifact are. If it's indeed going to keep getting published as is we should not remove it from our builds. Update: I created #359 as an alternative |
I'm thinking to go with this one for now and keep a close eye out on oracle/graal#7224 and do all necessary preparations to move to the new API maven artefact. |
On second thought, we might need to go with #359 after all so as to build |
This PR has the same problem when testing |
superseded by #360 |
Package was split in oracle/graal#7171
Depends on oracle/graal#7205