Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-43819] Split Graal-SDK into new modules: polyglot, word, collections and nativeimage. (Unchained Part 7) #7171

Merged
merged 11 commits into from
Aug 9, 2023

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Aug 9, 2023

Overview

This PR splits up the org.graalvm.sdk module into four separate modules:

  • org.graalvm.word
  • org.graalvm.collections
  • org.graalvm.polyglot
  • org.graalvm.nativeimage

For compatiblity we will still deploy a org.graalvm.sdk module to Maven which transitively export all new modules. This should be compatible unless someone uses something like --add-exports=org.graalvm.sdk/org.graalvm.nativeimage.impl=ALL-UNAMED it should remain compatible.

This PR also splits up the Graal SDK component into three:

  • Graal SDK Compiler - basically contains WORD and COLLECTIONS. Minimally required for the compiler to run.
  • Graal SDK Native Image - in addition to WORD and COLLECTIONS it also includes the NATIVEIMAGE module. This is the Graal SDK component that will beincluded in unchained builds that contain native-image.
  • Graal SDK - contains WORD, COLLECTIONS, NATIVEIMAGE, POLYGLOT and the compatibility distribution SDK. This component is still there only for compatibility and will not be deployed in any builds.

Other Noteworthy changes:

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 9, 2023
@graalvmbot graalvmbot merged commit 86f363c into master Aug 9, 2023
12 checks passed
@graalvmbot graalvmbot deleted the chumer/GR-43819/split-sdk branch August 9, 2023 15:37
zakkak added a commit to zakkak/quarkus that referenced this pull request Aug 16, 2023
zakkak added a commit to zakkak/mandrel-packaging that referenced this pull request Aug 17, 2023
zakkak added a commit to zakkak/mandrel-packaging that referenced this pull request Aug 17, 2023
zakkak added a commit to zakkak/quarkus that referenced this pull request Aug 17, 2023
zakkak added a commit to zakkak/quarkus that referenced this pull request Sep 12, 2023
oracle/graal#7171 splits graal-sdk in 4 new
modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1)
we need to remove those as well. Note that it's OK to have them marked
for removal even when using GraalVM < 23.1 despite them not actually
being present.

Closes quarkusio#35872
zakkak added a commit to zakkak/quarkus that referenced this pull request Sep 12, 2023
oracle/graal#7171 splits graal-sdk in 4 new
modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1)
we need to remove those as well. Note that it's OK to have them marked
for removal even when using GraalVM < 23.1 despite them not actually
being present.

Closes quarkusio#35872
zakkak added a commit to zakkak/quarkus that referenced this pull request Sep 12, 2023
oracle/graal#7171 splits graal-sdk in 4 new
modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1)
we need to remove those as well. Note that it's OK to have them marked
for removal even when using GraalVM < 23.1 despite them not actually
being present.

Closes quarkusio#35872
franz1981 pushed a commit to franz1981/quarkus that referenced this pull request Sep 13, 2023
oracle/graal#7171 splits graal-sdk in 4 new
modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1)
we need to remove those as well. Note that it's OK to have them marked
for removal even when using GraalVM < 23.1 despite them not actually
being present.

Closes quarkusio#35872
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Feb 8, 2024
oracle/graal#7171 splits graal-sdk in 4 new
modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1)
we need to remove those as well. Note that it's OK to have them marked
for removal even when using GraalVM < 23.1 despite them not actually
being present.

Closes quarkusio#35872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants