-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-43819] Split Graal-SDK into new modules: polyglot, word, collections and nativeimage. (Unchained Part 7) #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive-image; Migrate SVM options APIs; Migrate SVM to no longer use HomeFinder.
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Aug 9, 2023
This was referenced Aug 11, 2023
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Aug 16, 2023
Module names changed in oracle/graal#7171
zakkak
added a commit
to zakkak/mandrel-packaging
that referenced
this pull request
Aug 17, 2023
Package was split in oracle/graal#7171
zakkak
added a commit
to zakkak/mandrel-packaging
that referenced
this pull request
Aug 17, 2023
New packages introduced in oracle/graal#7171
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Aug 17, 2023
Module names changed in oracle/graal#7171
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 12, 2023
oracle/graal#7171 splits graal-sdk in 4 new modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1) we need to remove those as well. Note that it's OK to have them marked for removal even when using GraalVM < 23.1 despite them not actually being present. Closes quarkusio#35872
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 12, 2023
oracle/graal#7171 splits graal-sdk in 4 new modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1) we need to remove those as well. Note that it's OK to have them marked for removal even when using GraalVM < 23.1 despite them not actually being present. Closes quarkusio#35872
zakkak
added a commit
to zakkak/quarkus
that referenced
this pull request
Sep 12, 2023
oracle/graal#7171 splits graal-sdk in 4 new modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1) we need to remove those as well. Note that it's OK to have them marked for removal even when using GraalVM < 23.1 despite them not actually being present. Closes quarkusio#35872
franz1981
pushed a commit
to franz1981/quarkus
that referenced
this pull request
Sep 13, 2023
oracle/graal#7171 splits graal-sdk in 4 new modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1) we need to remove those as well. Note that it's OK to have them marked for removal even when using GraalVM < 23.1 despite them not actually being present. Closes quarkusio#35872
holly-cummins
pushed a commit
to holly-cummins/quarkus
that referenced
this pull request
Feb 8, 2024
oracle/graal#7171 splits graal-sdk in 4 new modules/artifacts. As a result starting with GraalVM for JDK 21 (23.1) we need to remove those as well. Note that it's OK to have them marked for removal even when using GraalVM < 23.1 despite them not actually being present. Closes quarkusio#35872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR splits up the org.graalvm.sdk module into four separate modules:
For compatiblity we will still deploy a org.graalvm.sdk module to Maven which transitively export all new modules. This should be compatible unless someone uses something like
--add-exports=org.graalvm.sdk/org.graalvm.nativeimage.impl=ALL-UNAMED
it should remain compatible.This PR also splits up the Graal SDK component into three:
Other Noteworthy changes:
BuildDirectoryProvider
as a replacement for HomeFinder. As HomeFinder will be part of the POLYGLOT API, as coupling with languages is much stronger. https://ol-bitbucket.us.oracle.com/projects/G/repos/graal/pull-requests/14984/diff#substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/BuildDirectoryProvider.java?t=34