Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that org members permissions are necessary #226

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Sep 20, 2024

Used for unassigning default reviewers. If you don't have it, you get cryptic comments posted back on the PR after the backport PRs are opened with the message Validation Failed: "Could not resolve to a node with the global id of '<NODE ID>."

Like in grafana/pyroscope#3557 (comment)

Used for unassigning default reviewers
@jdbaldry jdbaldry marked this pull request as ready for review September 20, 2024 12:58
@jdbaldry jdbaldry requested a review from a team as a code owner September 20, 2024 12:58
@jdbaldry jdbaldry merged commit 49a7ad1 into main Sep 20, 2024
3 checks passed
@jdbaldry jdbaldry deleted the jdbaldry-patch-1 branch September 20, 2024 13:35
jdbaldry added a commit to grafana/agent that referenced this pull request Sep 27, 2024
Use the default token injected into workflows since the GH_BOT_ACCESS_TOKEN is revoked.

The default token doesn't have the permission used for unassigning default reviewers. If you don't have it, you get cryptic comments posted back on the PR after the backport PRs are opened with the message `Validation Failed: "Could not resolve to a node with the global id of '<NODE ID>."`

Like in grafana/pyroscope#3557 (comment)

Behavior was documented in grafana/grafana-github-actions#226 and made configurable in 
grafana/grafana-github-actions#227

`removeDefaultReviewers: false` instructs the workflow to not try to avoid the error but will of course not remove the default reviewers assigned on the backport PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants