Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add release notes for v1.8 #3557

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

korniltsev
Copy link
Collaborator

No description provided.

@korniltsev korniltsev requested review from a team as code owners September 13, 2024 08:55
@korniltsev korniltsev added backport release/v1.8 This label will backport a merged PR to the release/v1.8 branch documentation Improvements or additions to documentation type/docs Improvements for doc docs. Used by Docs team for project management labels Sep 13, 2024
Copy link
Contributor

Hello @korniltsev!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev enabled auto-merge (squash) September 13, 2024 10:23
@korniltsev korniltsev merged commit 25b12bf into main Sep 13, 2024
18 checks passed
@korniltsev korniltsev deleted the korniltsev/release_notes_18 branch September 13, 2024 10:32
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
* docs: Add release notes for v1.8

* Update docs/sources/release-notes/v1-8.md

Co-authored-by: Marc Sanmiquel <[email protected]>

---------

Co-authored-by: Marc Sanmiquel <[email protected]>
(cherry picked from commit 25b12bf)
Copy link
Contributor

The backport to release/v1.8 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3557-to-release/v1.8 origin/release/v1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 25b12bf34acf45f26ba93a46745a39446f95da1a

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3557-to-release/v1.8
# Create the PR on GitHub
gh pr create --title '[release/v1.8] docs: Add release notes for v1.8' --body 'Backport 25b12bf34acf45f26ba93a46745a39446f95da1a from #3557' --label 'documentation' --label 'type/docs' --label 'backport' --base release/v1.8 --milestone release/v1.8 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3557-to-release/v1.8

# Create a pull request where the `base` branch is `release/v1.8` and the `compare`/`head` branch is `backport-3557-to-release/v1.8`.

# Remove the local backport branch
git switch main
git branch -D backport-3557-to-release/v1.8

korniltsev added a commit that referenced this pull request Sep 13, 2024
* docs: Add release notes for v1.8

* Update docs/sources/release-notes/v1-8.md

Co-authored-by: Marc Sanmiquel <[email protected]>

---------

Co-authored-by: Marc Sanmiquel <[email protected]>
(cherry picked from commit 25b12bf)

Co-authored-by: Tolya Korniltsev <[email protected]>
jdbaldry added a commit to grafana/agent that referenced this pull request Sep 27, 2024
Use the default token injected into workflows since the GH_BOT_ACCESS_TOKEN is revoked.

The default token doesn't have the permission used for unassigning default reviewers. If you don't have it, you get cryptic comments posted back on the PR after the backport PRs are opened with the message `Validation Failed: "Could not resolve to a node with the global id of '<NODE ID>."`

Like in grafana/pyroscope#3557 (comment)

Behavior was documented in grafana/grafana-github-actions#226 and made configurable in 
grafana/grafana-github-actions#227

`removeDefaultReviewers: false` instructs the workflow to not try to avoid the error but will of course not remove the default reviewers assigned on the backport PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.8 This label will backport a merged PR to the release/v1.8 branch backport-failed documentation Improvements or additions to documentation type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants