-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate Grafonnet for Grafana v11.0.0 #199
Conversation
BREAKING CHANGE: This will drop support for regenerating <v11.0.0 versions of Grafonnet, any backports will need manual intervention from here on.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
@@ -282,7 +282,7 @@ PARAMETERS: | |||
* **value** (`boolean`) | |||
- default value: `true` | |||
|
|||
|
|||
?? default is missing or false ?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That comes from the schemas, I just scanned for that sentence but can't find the source immediately, cc/ @K-Phoen, do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll leave it as such.
@@ -378,6 +380,28 @@ PARAMETERS: | |||
* **value** (`object`) | |||
|
|||
TODO docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo? We've now got docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That comes from the upstream schemas in grafana/grafana, authors of that panel should document this.
@@ -19,7 +19,6 @@ jb init | |||
cp -r "${REPO_DIR}/generator" generator | |||
cp -r "${REPO_DIR}/generator/jsonnetfile.lock.json" . | |||
jb install | |||
jb install "github.com/grafana/grok/jsonnet/${VERSION}@main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!
I found some breaking changes described in grafana/grafonnet#199, and this adjusts for those. Before adjusting we got errors, so the breaking change was loud.
Update the generator to use foundation-sdk, this means the generator now only works for generating Grafonnet for Grafana v11+. If older generated libraries need updates/backporting, this'll require manual intervention.
Notable changes:
libraryPanel
grafonnet.query.expr
AlertGroups
panel is no longer supported in Grafana v11withType(value) -> withType()
Candlestick
panel: CandlestickFieldMap no longer nestedHeatmap
panel: HeatmapTooltip, FilterValueRange, HeatmapColorOptions and CellValues no longer nestedTable
panel: TableFooterOptions no longer nestedPrometheus
query:scope
field got removedThere are a bunch more minor changes and docs updates.
Diff hint for the reviewer: