Update grafonnet from v10.4.0 to v11.1.0, Grafana v11.1.0 is now required #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found some breaking changes described in grafana/grafonnet#199, and this adjusts for those. Before adjusting we got errors, so the breaking change was loud.
2 tasks
consideRatio
changed the title
GeorgianaElena
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
This looks good to me @consideRatio!
Since we don't have yet a changelong, maybe we can state the compatibility with grafana version 11.1.0 in the docs at https://jupyterhub-grafana.readthedocs.io/en/latest/tutorials/deploy.html
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only breaking change I needed to adjust for in 800bbcc were described in grafana/grafonnet#199 among other breaking changes that didn't affect us. Without adjusting, the failure was loud and informative!
I think rendered dashboard may require grafana version 11.1.0 as well which has been available since June 25, 2024, and due to that, this can be considered a breaking change.