Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip blocks with out-of-order chunks in compactor #145

Open
pracucci opened this issue Aug 17, 2021 · 1 comment
Open

Skip blocks with out-of-order chunks in compactor #145

pracucci opened this issue Aug 17, 2021 · 1 comment

Comments

@pracucci
Copy link
Collaborator

The PR #142 upgraded Thanos including a feature in the compactor that can skip blocks with out-of-order chunks. The feature is based on the no-compact Thanos marker which is currently not supported by Mimir, but we should add support.

Some things to keep in mind to add support:

  • Add no-compact marker support to global location (see BucketWithGlobalMarkers)
  • Add no-compact marker support to bucket-index (see pkg/storage/tsdb/bucketindex)
  • Add option to enable "skip blocks with out-of-order chunks" and pass it to NewBucketCompactor
  • Add a new metric to track the number of blocks marked for no-compact and pass it to NewDefaultGrouper
@56quarters
Copy link
Contributor

56quarters commented Aug 17, 2021

There is a draft (at the moment) PR to do this in Cortex [PR 4423]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants