-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compactor: Remove BlockDeletionMarksMigrationEnabled #122
Conversation
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
@pracucci @pstibrany any suggestions on how to fix the failing tests? |
Failing tests need to be updated too. They're testing the markers migration. We also need a CHANGELOG entry. @pstibrany No migration is required to build #145 because we don't have no-compact markers yet, right? I just wanna make sure we're not removing the support to migration and then we'll add it back for #145. |
That's right. I'm not aware of Cortex/Mimir having or using no-compact markers. |
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
@pstibrany @pracucci looks as if I could fix tests, PTAL. |
@09jvilla @mattmendick what's your opinion on this change, is it good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I left a comment about the CHANGELOG. A part from this, we can merge if/once we get the green light from Jen and Matt.
Co-authored-by: Marco Pracucci <[email protected]>
Yall can go ahead and merge. We'll make a note for customers upgrading to GEM 1.6 that they must go through GEM 1.5, which should ensure we have no issues. |
cc @mattmendick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a code review, but just confirming this is ok with the GEM team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have also ensured that we already have a ticket for the next GEM release (https://github.com/grafana/backend-enterprise/issues/2063) so we don't forget to mention that in the changelog.
Thanks Christian :) much appreciated.
…On Wed, Aug 18, 2021 at 9:37 AM Christian Simon ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM.
I have also ensured that we already have a ticket for the next GEM release
(grafana/backend-enterprise#2063
<grafana/backend-enterprise#2063>) so we don't
forget to mention that in the changelog.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#122 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJKMQEHMT6Y7KZIN3PCCFTT5PASJANCNFSM5B6RHXEQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Then we merge! Worst case scenario, rolling back this change is not a tragedy. |
What this PR does:
Address TODO and remove
BlockDeletionMarksMigrationEnabled
in compactor code.Which issue(s) this PR fixes:
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]