Upgrade Thanos and simplify store-gateway metrics #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In #123 we've started to simplify store-gateway metrics and in this PR I'm completing the work. This PR is based on a change done in Thanos (PR) to allow to share the same metrics between multiple index-header lazy reader pools.
To bring in the Thanos change I had to upgrade Thanos too. It includes a couple of changes affecting us too:
The change to skip compaction for blocks with out-of-order chunk is very interesting but can't leverage on it right away because we don't support no-compact marker (eg. not stored in global markers location, not part of bucket-index, ...). I will open an issue with follow up work to be done to add support for it in Mimir too.
I've done a manual test and index-header lazy loader metrics look good.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]