Simplify store gateway metrics #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
simplify-store-gateway-metrics
branch
from
c5aba88
to
bf430e2
Compare
pracucci
commented
Aug 11, 2021
| @@ -89,174 +88,16 @@ const ( | |||
| labelDecode = "decode" | |||
| ) | |||
|
|
|||
| type bucketStoreMetrics struct { | |||
There was a problem hiding this comment.
Moved to pkg/storegateway/bucket_store_metrics.go
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Now that we imported Thanos
BucketStoreinto Mimir, we can simplify theBucketStoremetrics and avoid having to aggregate its metrics via Registerer wrapper (we still need it for index-header lazy loader metrics, which I will try to address separately in Thanos).I've done a manual test and I think the refactoring is a noop from the user perspective, except that will use less CPU and memory to export metrics from store-gateway if you have a large number of tenants.
Which issue(s) this PR fixes:
Fixes partially #102
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]